Bugzilla – Attachment 20362 Details for
Bug 10663
Holds never block renewals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED_QA] Bug 10663 - Revert and use CheckReserves for CanBookBeRenewed
Bug-10663---Revert-and-use-CheckReserves-for-CanBo.patch (text/plain), 1.70 KB, created by
Marcel de Rooy
on 2013-08-15 11:22:37 UTC
(
hide
)
Description:
[PASSED_QA] Bug 10663 - Revert and use CheckReserves for CanBookBeRenewed
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-08-15 11:22:37 UTC
Size:
1.70 KB
patch
obsolete
>From 1f3c60d01f7fb603f2731648a42c927f3af8ba5e Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Mon, 5 Aug 2013 15:23:44 -0300 >Subject: [PATCH] Bug 10663 - Revert and use CheckReserves for > CanBookBeRenewed >Content-Type: text/plain; charset=utf-8 > >It makes renewal lock by holds work again. >Unit tests as follow up > >Regards >To+ > >Sponsored-by: Universidad Nacional de Cordoba >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >This reverts changes made to CanBookBeRenewed by >patches from bug 9376. >GetReserveStatus is not suitable to recognize if an item >can fild a hold on return and CheckReserves is restored. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Bug 10663: Follow-up - Revert and use CheckReserves for CanBookBeRenewed > >CheckReserves returns '' when no reserve is found, >so $resfound will always be defined and we need to >check if it's true. > >This is part of the revert. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Squashed the above two patches. Works as advertised. >--- > C4/Circulation.pm | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index ca66931..c578213 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2484,8 +2484,9 @@ sub CanBookBeRenewed { > $error = "too_many"; > } > >- my $resstatus = C4::Reserves::GetReserveStatus($itemnumber); >- if ( $resstatus eq "Waiting" or $resstatus eq "Reserved" ) { >+ my ( $resfound, $resrec, undef ) = C4::Reserves::CheckReserves( $itemnumber ); >+ >+ if ( $resfound ) { # '' when no hold was found > $renewokay = 0; > $error = "on_reserve"; > } >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10663
:
19987
|
20129
|
20139
|
20140
|
20148
|
20149
|
20150
|
20151
|
20152
|
20153
|
20154
|
20155
|
20156
| 20362 |
20363
|
20364
|
22913