From ad7e12560cff5f4baf3ca72789cb7bb6efbcdb2b Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 15 Jul 2013 08:41:51 -0400 Subject: [PATCH] [PASSED QA] Bug 7639 - system preference to forgive fines on lost items - QA Followup - Fix update description Signed-off-by: Katrin Fischer With these patches we now have 3 preferences that deal with fines/fees and lost items: Replacement price - On marking lost: WhenLostChargeReplacementFee - On return: RefundLostItemFeeOnReturn (preexisting) Overdue fines - On marking lost: WhenLostForgiveFine System preferences work according to their description. Further notes: - Patches pass all tests and QA script. - LostItem is changed and needs unit tests. All occurrences of LostItem have been changed. - Database update is ok. I had to fix the sysprefs.sql file that has been recently rewritten and alphabetized. --- installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 25548ff..60b177f 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -7072,7 +7072,7 @@ $DBversion = "3.13.00.XXX"; if (C4::Context->preference("Version") < TransformToNum($DBversion)) { $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostForgiveFine','0',NULL,'If ON, Forgives the fines on an item when it is lost.','YesNo')"); $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostChargeReplacementFee','1',NULL,'If ON, Charge the replacement price when a patron loses an item.','YesNo')"); - print "Upgrade to $DBversion done (Bug 7639: Added sysprefs WhenLostForgiveFine and WhenLostChargeReplacementFee)\n"; + print "Upgrade to $DBversion done (Bug 7639: system preferences to forgive fines on lost items)\n"; SetVersion ($DBversion); } -- 1.7.9.5