Bugzilla – Attachment 20521 Details for
Bug 10743
add style to privacy rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10743: Add styles to 'my privacy' page in OPAC
PASSED-QA-Bug-10743-Add-styles-to-my-privacy-page-.patch (text/plain), 2.93 KB, created by
Katrin Fischer
on 2013-08-21 06:44:19 UTC
(
hide
)
Description:
[PASSED QA] Bug 10743: Add styles to 'my privacy' page in OPAC
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-08-21 06:44:19 UTC
Size:
2.93 KB
patch
obsolete
>From 2691357685653bcc3aa1009983bfd30b080e0ea8 Mon Sep 17 00:00:00 2001 >From: "Nicole C. Engard" <nengard@bywatersolutions.com> >Date: Thu, 15 Aug 2013 22:08:41 -0400 >Subject: [PATCH] [PASSED QA] Bug 10743: Add styles to 'my privacy' page in > OPAC > >This patch does a couple things. Most importantly it adds >a new div around the privacy rules summary so that it can >be easily changed. It also moves the start of the form to >right above the form's select box so that it's not in the >new privacy rules div. > >To test: > >* Apply patch >* Enable the use of privacy via the sys prefs >* Log in to the OPAC >* Visit the 'my privacy' tab >* Make sure it looks okay >* Submit the form and make sure it works >* Repeat in the other theme > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Edit: Replaced a few tabs with spaces to keep the QA script happy. >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works nicely, privacy options can still be edited. >--- > .../opac-tmpl/prog/en/modules/opac-privacy.tt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt >index 3bb988f..1106973 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt >@@ -20,13 +20,11 @@ > [% IF ( privacy_updated ) %] > <div class="dialog message">Your privacy rules have been updated.</div> > [% END %] >- >+ <div id="userprivacyrules" class="container"> > <h2>Privacy rule</h2> > [% IF ( Ask_data ) %] > <p>We take great care in protecting your privacy. On this screen, you can define how long we keep your reading history.</p> > <p>Your options are: <p> >- <form action="/cgi-bin/koha/opac-privacy.pl" method="post" id="opac-privacy-update-form"> >- <input type="hidden" name="op" value="update_privacy" /> > <ul id="opac-privacy-options-list"> > <li class="privacy0">Forever: keep my reading history without limit. This is the option for users who want to keep track of what they are reading.</li> > <li class="privacy1">Default: keep my reading history according to local laws. This is the default option : the library will keep your reading history for the duration permitted by local laws.</li> >@@ -34,6 +32,9 @@ > </ul> > <p id="note1">Please note that information on any book still checked-out must be kept by the library no matter which privacy option you choose.</p> > <p id="note2">Please also note that the library staff can't update these values for you: it's your privacy!</p> >+ </div> >+ <form action="/cgi-bin/koha/opac-privacy.pl" method="post" id="opac-privacy-update-form"> >+ <input type="hidden" name="op" value="update_privacy" /> > <label for:"privacy">Please choose your privacy rule:</label> > <select name="privacy"> > [% IF ( privacy0 ) %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10743
:
20413
|
20506
| 20521