From 00278e9e20aa194da747bedb489c128019aec732 Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Fri, 16 Aug 2013 13:53:04 +0200 Subject: [PATCH] Bug 10741 - Formatting can place hold test Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack --- C4/Search.pm | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index 4e4edb0..753d5ae 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1939,23 +1939,17 @@ sub searchResults { $item_onhold_count++ if $reservestatus eq 'Waiting'; $item->{status} = $item->{wthdrawn} . "-" . $item->{itemlost} . "-" . $item->{damaged} . "-" . $item->{notforloan}; - # can place hold on item ? - if ( !$item->{itemlost} ) { - if ( !$item->{wthdrawn} ){ - if ( $item->{damaged} ){ - if ( C4::Context->preference('AllowHoldsOnDamagedItems') ){ - # can place a hold on a damaged item if AllowHoldsOnDamagedItems is true - if ( ( !$item->{notforloan} || $item->{notforloan} < 0 ) ){ - # item is either for loan or has notforloan < 0 - $can_place_holds = 1; - } - } - } elsif ( !$item->{notforloan} || $item->{notforloan} < 0 ) { - # item is not damaged and item is either for loan or has notforloan < 0 - $can_place_holds = 1; - } - } - } + # can place a hold on a item if + # not lost nor withdrawn + # not damaged unless AllowHoldsOnDamagedItems is true + # item is either for loan or on order (notforloan < 0) + $can_place_holds = 1 + if ( + !$item->{itemlost} + && !$item->{wthdrawn} + && ( !$item->{damaged} || C4::Context->preference('AllowHoldsOnDamagedItems') ) + && ( !$item->{notforloan} || $item->{notforloan} < 0 ) + ); $other_count++; -- 1.8.1.2