From d3425a70d70819ad312c8fa1c02a13c96503f456 Mon Sep 17 00:00:00 2001 From: David Cook Date: Wed, 21 Aug 2013 12:12:36 +1000 Subject: [PATCH] [PASSED QA] Bug 9603 - Fix layout of Patron Card Creator Layout screen for display in IE Currently, the layout for the Edit/Add Layout screen of the Patron Card Creator is in complete disarray, when viewed in Internet Explorer (of any version). The nav bar is pushed to the bottom of the page, every fieldset is empty (as their contents have been pushed out into different parts of the page), and the checkboxes don't work. The cause appears to be some extraneous mark-up (a few extra fieldset and li elements)and some missing mark-up (ol elements to wrap the list elements, especially when nesting lists within each other and within div elements). Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer I didn't test this in IE, but changes are fixing general problems with HTML validity. Checking the page with the W3C validator: Before: 27 Errors, 7 warning(s) After: 6 Errors, 7 warning(s) All tests and QA script pass, page looks alright. Would be nice to see the remaining problems fixed in a follow-up. --- .../prog/en/modules/patroncards/edit-layout.tt | 32 +++++++++++++++++--- 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt index 798ad48..606a6ac 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt @@ -130,6 +130,7 @@
  • General settings +
    1. @@ -168,11 +169,13 @@ Off [% END %]
    2. +
  • Text fields +
    1. [% IF ( field_1 ) %] @@ -181,6 +184,7 @@ Field 1 [% END %]
    2. @@ -233,6 +238,7 @@ Field 2 [% END %]
  • @@ -285,6 +292,7 @@ Field 3 [% END %] - - - - + @@ -357,6 +363,7 @@
  • Barcode +
    1. [% IF ( barcode_print ) %] @@ -365,7 +372,9 @@ [% END %]
    2. +
  • Images +
    1. Image 1 +
      1. +
      @@ -453,6 +470,7 @@
    2. Image 2 +
      1. +
      @@ -500,6 +523,7 @@
    3. +
  • -- 1.7.9.5