@@ -, +, @@ Test plan : - define an overdue notice containing some valid substitution terms + some valid html tags ( or
Without patch, your html tags are missing in your html file With the patch, they are present and can be used with a css to generate a formatted pdf file. If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template. --- misc/cronjobs/overdue_notices.pl | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) --- a/misc/cronjobs/overdue_notices.pl +++ a/misc/cronjobs/overdue_notices.pl @@ -568,8 +568,6 @@ END_SQL if (@misses) { $verbose and warn "The following terms were not matched and replaced: \n\t" . join "\n\t", @misses; } - $letter->{'content'} =~ s/\<[^<>]*?\>//g; # Now that we've warned about them, remove them. - $letter->{'content'} =~ s/\<[^<>]*?\>//g; # 2nd pass for the double nesting. if ( !$nomail && scalar @emails_to_use ) { C4::Letters::EnqueueLetter( --