From 6d70710b5a9c900975f01c6adc5500d34157abc9 Mon Sep 17 00:00:00 2001 From: Magnus Enger Date: Sat, 31 Aug 2013 15:33:24 +0200 Subject: [PATCH] [PASSED QA] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl The synopsis for the -html option used to be: -html Output html to file but the argument to this option should actually be a directory, not a filename. This patch fixes the synopsis. To test: - Run perldoc misc/cronjobs/overdue_notices.pl - Check that the synopsis is as shown above - Apply this patch - Run perldoc misc/cronjobs/overdue_notices.pl - Check that - the synopsis asks for a directory, not a filename - that the description of the -html option further down in the perldoc now mentions the filename that the HTML file will be created with. Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No koha-qa errors. If feeded with a filename -html option fails with many messages like print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384. Perhaps it could be improved, but that was the old behavior. Signed-off-by: Katrin Fischer Improves documentation, no negative side effects found. --- misc/cronjobs/overdue_notices.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 0f263c4..598f922 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -60,7 +60,7 @@ overdue_notices.pl -max maximum days overdue to deal with -library only deal with overdues from this library (repeatable : several libraries can be given) -csv populate CSV file - -html Output html to file + -html Output html to a file in the given directory -itemscontent item information in templates -borcat category code that must be included -borcatout category code that must be excluded @@ -113,6 +113,8 @@ overdues that could not be emailed are sent in CSV format to the admin. Produces html data. if patron does not have a mail address or -n (no mail) flag is set, an html file is generated in the specified directory. This can be downloaded or futher processed by library staff. +The file will be called notices-YYYY-MM-DD.html and placed in the directory +specified. =item B<-itemscontent> -- 1.7.9.5