From ac00abd55ef83e795736f99cdf1f5c92d6ef008b Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Tue, 18 Jun 2013 10:34:18 -0400
Subject: [PATCH] Bug 8836 - Resurrect Rotating Collections - QA Followup
---
C4/RotatingCollections.pm | 42 +++++++++++++-------------
rotating_collections/addItems.pl | 4 +--
rotating_collections/editCollections.pl | 5 +--
rotating_collections/rotatingCollections.pl | 4 +--
rotating_collections/transferCollection.pl | 4 +--
5 files changed, 26 insertions(+), 33 deletions(-)
diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm
index 09b5216..0b7d60e 100644
--- a/C4/RotatingCollections.pm
+++ b/C4/RotatingCollections.pm
@@ -22,10 +22,7 @@ package C4::RotatingCollections;
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-use strict;
-#use warnings; FIXME - Bug 2505
-
-require Exporter;
+use Modern::Perl;
use C4::Context;
use C4::Circulation;
@@ -47,23 +44,26 @@ C4::RotatingCollections - Functions for managing rotating collections
=cut
-@ISA = qw( Exporter );
-@EXPORT = qw(
- CreateCollection
- UpdateCollection
- DeleteCollection
-
- GetItemsInCollection
+BEGIN {
+ require Exporter;
+ @ISA = qw( Exporter );
+ @EXPORT = qw(
+ CreateCollection
+ UpdateCollection
+ DeleteCollection
- GetCollection
- GetCollections
-
- AddItemToCollection
- RemoveItemFromCollection
- TransferCollection
+ GetItemsInCollection
- GetCollectionItemBranches
-);
+ GetCollection
+ GetCollections
+
+ AddItemToCollection
+ RemoveItemFromCollection
+ TransferCollection
+
+ GetCollectionItemBranches
+ );
+}
=head2 CreateCollection
( $success, $errorcode, $errormessage ) = CreateCollection( $title, $description );
diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl
index 06b6b3a..7302db2 100755
--- a/rotating_collections/addItems.pl
+++ b/rotating_collections/addItems.pl
@@ -16,9 +16,7 @@
# Suite 330, Boston, MA 02111-1307 USA
#
-use strict;
-#use warnings; FIXME - Bug 2505
-require Exporter;
+use Modern::Perl;
use C4::Output;
use C4::Auth;
diff --git a/rotating_collections/editCollections.pl b/rotating_collections/editCollections.pl
index e386608..a6e2f8b 100755
--- a/rotating_collections/editCollections.pl
+++ b/rotating_collections/editCollections.pl
@@ -15,9 +15,8 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
#
-use strict;
-#use warnings; FIXME - Bug 2505
-require Exporter;
+
+use Modern::Perl;
use CGI;
diff --git a/rotating_collections/rotatingCollections.pl b/rotating_collections/rotatingCollections.pl
index 35aea56..d574692 100755
--- a/rotating_collections/rotatingCollections.pl
+++ b/rotating_collections/rotatingCollections.pl
@@ -16,9 +16,7 @@
# Suite 330, Boston, MA 02111-1307 USA
#
-use strict;
-#use warnings; FIXME - Bug 2505
-require Exporter;
+use Modern::Perl;
use CGI;
diff --git a/rotating_collections/transferCollection.pl b/rotating_collections/transferCollection.pl
index 23eff46..8673b83 100755
--- a/rotating_collections/transferCollection.pl
+++ b/rotating_collections/transferCollection.pl
@@ -16,9 +16,7 @@
# Suite 330, Boston, MA 02111-1307 USA
#
-use strict;
-#use warnings; FIXME - Bug 2505
-require Exporter;
+use Modern::Perl;
use C4::Output;
use C4::Auth;
--
1.7.2.5