Bugzilla – Attachment 21320 Details for
Bug 10856
Improve the previous and next items on the shelf browser
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10856: If callnumbers are equals, order should be on itemnumbers
PASSED-QA-Bug-10856-If-callnumbers-are-equals-orde.patch (text/plain), 2.14 KB, created by
Katrin Fischer
on 2013-09-22 18:38:16 UTC
(
hide
)
Description:
[PASSED QA] Bug 10856: If callnumbers are equals, order should be on itemnumbers
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-09-22 18:38:16 UTC
Size:
2.14 KB
patch
obsolete
>From e9357994a2b1910b17411fef16352bf4b94ba49c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 13 Sep 2013 09:55:51 +0200 >Subject: [PATCH] [PASSED QA] Bug 10856: If callnumbers are equals, order > should be on itemnumbers > >If a lot of items has the same callnumber, the order should be on the >itemnumbers. Otherwise the left side is always filled with the same >items. > >+ Fix a bad c/p for the next link (when js is disabled). > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > C4/ShelfBrowser.pm | 2 +- > .../opac-tmpl/prog/en/includes/shelfbrowser.inc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/ShelfBrowser.pm b/C4/ShelfBrowser.pm >index 555ad05..763b406 100644 >--- a/C4/ShelfBrowser.pm >+++ b/C4/ShelfBrowser.pm >@@ -171,7 +171,7 @@ sub GetNearbyItems { > > my @prev_items = @{ > $dbh->selectall_arrayref( >- $prev_query . $query_cond . ' ORDER BY cn_sort DESC, itemnumber LIMIT ?', >+ $prev_query . $query_cond . ' ORDER BY cn_sort DESC, itemnumber DESC LIMIT ?', > { Slice => {} }, > ( @params, $gap ) > ) >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc >index c41647a..f5672f9 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc >@@ -67,7 +67,7 @@ > <td rowspan="2" style="width:20px;"> > [% IF shelfbrowser_next_item %] > <div id="browser_next"> >- <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% shelfbrowser_prev_item.biblionumber %]&shelfbrowse_itemnumber=[% shelfbrowser_prev_item.itemnumber %]#shelfbrowser">Next</a> >+ <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% shelfbrowser_next_item.biblionumber %]&shelfbrowse_itemnumber=[% shelfbrowser_next_item.itemnumber %]#shelfbrowser">Next</a> > </div> > [% END %] > </td> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10856
:
20964
|
20965
|
21002
|
21071
|
21136
|
21137
|
21138
|
21211
|
21319
|
21320
|
21321
|
21508
|
21666
|
21670
|
21671
|
21672
|
21673