From 05dfc4e8ed932eb16ed40bf60dce6f6317fc498f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 17 Jun 2013 12:11:27 +0200 Subject: [PATCH] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart --- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 ++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index a389a90..8daed6c 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -347,7 +347,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('SpineLabelShowPrintOnBibDetails','0','','If turned on, a \"Print Label\" link will appear for each item on the bib details page in the staff interface.','YesNo'), ('StaffAuthorisedValueImages','1',NULL,'','YesNo'), ('staffClientBaseURL','',NULL,'Specify the base URL of the staff client','free'), -('StaffDetailItemSelection', '0', NULL, 'Enable item selection in record detail page', 'YesNo'); +('StaffDetailItemSelection', '1', NULL, 'Enable item selection in record detail page', 'YesNo'); ('StaffSerialIssueDisplayCount','3','','Number of serial issues to display per subscription in the Staff client','Integer'), ('StaticHoldsQueueWeight','0',NULL,'Specify a list of library location codes separated by commas -- the list of codes will be traversed and weighted with first values given higher weight for holds fulfillment -- alternatively, if RandomizeHoldsQueueWeight is set, the list will be randomly selective','Integer'), ('SubfieldsToUseWhenPrefill','','','Define a list of subfields to use when prefilling items (separated by space)','Free'), diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index e6a54de..4894008 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -7143,7 +7143,7 @@ $DBversion = "XXX"; if (C4::Context->preference('Version') < TransformToNum($DBversion)) { $dbh->do(qq{ INSERT INTO systempreferences (variable, value, explanation, options, type) - VALUES ('StaffDetailItemSelection', '0', 'Enable item selection in record detail page', NULL, 'YesNo') + VALUES ('StaffDetailItemSelection', '1', 'Enable item selection in record detail page', NULL, 'YesNo') }); print "Upgrade to $DBversion done (Add system preference StaffDetailItemSelection)\n"; SetVersion($DBversion); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 1f8274b..7914ee9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -149,6 +149,9 @@ function verify_images() { if (table.find('thead tr.columnFilter').length == 0) { table.dataTable().columnFilter({ 'sPlaceHolder': 'head:after' + [% IF StaffDetailItemSelection %] + , aoColumns: [ null, 'text', 'text', 'text', 'text', 'text', 'text', 'text' ] + [% END %] }); filters_row.addClass('columnFilter'); } @@ -198,6 +201,11 @@ function verify_images() { 'sDom': 't', 'bPaginate': false, 'bAutoWidth': false + [% IF StaffDetailItemSelection %] + , "aoColumnDefs": [ + { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false } + ] + [% END %] })); // Show a link to activate filtering -- 1.7.10.4