From 7570886cc52eb3f92c9af5c9d6e65c57b028c8d9 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 18 Jul 2013 12:10:44 +0200 Subject: [PATCH] Bug 2720: Unit tests improvements Create the patron. Use a transaction. Signed-off-by: Jonathan Druart --- t/db_dependent/Borrower_Debarments.t | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/t/db_dependent/Borrower_Debarments.t b/t/db_dependent/Borrower_Debarments.t index 1ee1ebe..88141f6 100755 --- a/t/db_dependent/Borrower_Debarments.t +++ b/t/db_dependent/Borrower_Debarments.t @@ -1,32 +1,24 @@ #!/usr/bin/perl -use strict; -use warnings; +use Modern::Perl; use C4::Context; use C4::Members; use Test::More tests => 18; -BEGIN { - use FindBin; - use lib $FindBin::Bin; - use_ok('Koha::Borrower::Debarments'); -} +use_ok('Koha::Borrower::Debarments'); -# Get a borrower with no current debarments -my $dbh = C4::Context->dbh; -my $query = " - SELECT b.borrowernumber FROM borrowers b - LEFT JOIN borrower_debarments bd ON ( b.borrowernumber = bd.borrowernumber ) - WHERE b.debarred IS NULL AND b.debarredcomment IS NULL AND bd.borrowernumber IS NULL - LIMIT 1 -"; -my $sth = $dbh->prepare($query); -$sth->execute; -my ($borrowernumber) = $sth->fetchrow_array(); -diag("Using borrowernumber: $borrowernumber"); +my $dbh = C4::Context->dbh; +$dbh->{AutoCommit} = 0; +$dbh->{RaiseError} = 1; +my $borrowernumber = AddMember( + firstname => 'my firstname', + surname => 'my surname', + categorycode => 'S', + branchcode => 'CPL', +); my $success = AddDebarment({ borrowernumber => $borrowernumber, @@ -99,4 +91,6 @@ foreach my $d ( @$debarments ) { DelDebarment( $d->{'borrower_debarment_id'} ); } $debarments = GetDebarments({ borrowernumber => $borrowernumber }); -ok( @$debarments == 0, "DelDebarment functions correctly" ) \ No newline at end of file +ok( @$debarments == 0, "DelDebarment functions correctly" ); + +$dbh->rollback; -- 1.7.10.4