Bugzilla – Attachment 21456 Details for
Bug 10917
Librarian cannot update hold pickup location without modify_holds_priority
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority
SIGNED-OFF-Bug-10917---Librarian-cannot-update-hol.patch (text/plain), 3.40 KB, created by
Owen Leonard
on 2013-09-25 17:46:40 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10917 - Librarian cannot update hold pickup location without modify_holds_priority
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-09-25 17:46:40 UTC
Size:
3.40 KB
patch
obsolete
>From 86d8eb9d8f4f74519428d6d3abf2ba4a54a4a63b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 19 Sep 2013 12:18:11 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 10917 - Librarian cannot update hold pickup > location without modify_holds_priority >Content-Type: text/plain; charset="utf-8" > >A librarian cannot modify a hold's pickup location unless he or she has >the permission modify_holds_priority. This appears to be a bug and not >by design. The reason the update fails is due to the priority not being >passed to ModReserve. The priority is not displayed when a librarian >does not have the modify_holds_priority permission. > >Test Plan: >1) Remove the modify_holds_priority from your logged in user > * User cannot be a superlibrarian >2) Attempt to change the pickup location for a hold >3) Note the change fails >4) Apply this patch >5) Repeat step 2 >6) Note the change succeeds > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/reserve/request.tt | 31 +++++++++++++------- > 1 file changed, 20 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 20853b3..7f7d05f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -600,17 +600,26 @@ function checkMultiHold() { > <input type="hidden" name="borrowernumber" value="[% reserveloo.borrowernumber %]" /> > <input type="hidden" name="biblionumber" value="[% reserveloo.biblionumber %]" /> > <select name="rank-request"> >- [% IF ( reserveloo.wait ) %] >- [% IF ( reserveloo.intransit ) %] >- <option value="T" selected="selected">In transit</option> >- [% ELSE %] >- <option value="W" selected="selected">Waiting</option> >- [% END %] >- [% END %] >- [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %][% FOREACH optionloo IN reserveloo.optionloop %] >- [% IF ( optionloo.selected ) %]<option value="[% optionloo.num %]" selected="selected">[% optionloo.num %]</option>[% ELSE %]<option value="[% optionloo.num %]">[% optionloo.num %]</option>[% END %] >- [% END %][% ELSE %]<option value=""></option>[% END %] >- <option value="del">del</option> >+ [% IF ( reserveloo.wait ) %] >+ [% IF ( reserveloo.intransit ) %] >+ <option value="T" selected="selected">In transit</option> >+ [% ELSE %] >+ <option value="W" selected="selected">Waiting</option> >+ [% END %] >+ [% END %] >+ >+ [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] >+ [% FOREACH optionloo IN reserveloo.optionloop %] >+ [% IF ( optionloo.selected ) %] >+ <option value="[% optionloo.num %]" selected="selected">[% optionloo.num %]</option> >+ [% ELSE %] >+ <option value="[% optionloo.num %]">[% optionloo.num %]</option> >+ [% END %] >+ [% END %] >+ [% ELSIF !reserveloo.wait %] >+ <option value="[% reserveloo.priority %]" selected="selected">[% reserveloo.priority %]</option> >+ [% END %] >+ <option value="del">del</option> > </select> > </td> > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10917
:
21255
|
21456
|
21827