Bugzilla – Attachment 21666 Details for
Bug 10856
Improve the previous and next items on the shelf browser
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10856: Fix cover display in shelf browser
SIGNED-OFF-Bug-10856-Fix-cover-display-in-shelf-br.patch (text/plain), 4.80 KB, created by
Owen Leonard
on 2013-09-30 16:43:12 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10856: Fix cover display in shelf browser
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-09-30 16:43:12 UTC
Size:
4.80 KB
patch
obsolete
>From 50d1a6fbfcc7ddb096922d42f9f87c2dcc812f2c Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 27 Sep 2013 11:48:01 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 10856: Fix cover display in shelf browser >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../opac-tmpl/prog/en/includes/shelfbrowser.inc | 18 ++++++++++++++++++ > koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js | 4 ++-- > koha-tmpl/opac-tmpl/prog/en/js/localcovers.js | 4 ++-- > koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js | 2 +- > 4 files changed, 23 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc >index b910592..e991766 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/shelfbrowser.inc >@@ -100,6 +100,15 @@ > }, > success: function(data){ > $("#shelfbrowser").replaceWith(data); >+ [% IF ( GoogleJackets ) %] >+ KOHA.Google.GetCoverFromIsbn([% covernewwindow %]); >+ [% END %] >+ [% IF OpenLibraryCovers %] >+ KOHA.OpenLibrary.GetCoverFromIsbn(); >+ [% END %] >+ [% IF OPACLocalCoverImages %] >+ KOHA.LocalCover.GetCoverFromBibnumber(true); >+ [% END %] > } > }); > }); >@@ -115,6 +124,15 @@ > }, > success: function(data){ > $("#shelfbrowser").replaceWith(data); >+ [% IF ( GoogleJackets ) %] >+ KOHA.Google.GetCoverFromIsbn([% covernewwindow %]); >+ [% END %] >+ [% IF OpenLibraryCovers %] >+ KOHA.OpenLibrary.GetCoverFromIsbn(); >+ [% END %] >+ [% IF OPACLocalCoverImages %] >+ KOHA.LocalCover.GetCoverFromBibnumber(true); >+ [% END %] > } > }); > }); >diff --git a/koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js b/koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js >index f129c38..b23599f 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js >+++ b/koha-tmpl/opac-tmpl/prog/en/js/google-jackets.js >@@ -51,7 +51,7 @@ KOHA.Google = { > if (typeof(book.thumbnail_url) != "undefined") { > var img = document.createElement("img"); > img.src = book.thumbnail_url; >- $(this).append(img); >+ $(this).empty().append(img); > var re = /^gbs-thumbnail-preview/; > if ( re.exec($(this).attr("id")) ) { > $(this).append( >@@ -67,7 +67,7 @@ KOHA.Google = { > var message = document.createElement("span"); > $(message).attr("class","no-image"); > $(message).html(NO_GOOGLE_JACKET); >- $(this).append(message); >+ $(this).empty().append(message); > } > }); > } >diff --git a/koha-tmpl/opac-tmpl/prog/en/js/localcovers.js b/koha-tmpl/opac-tmpl/prog/en/js/localcovers.js >index 6d24798..7bd7ae2 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/js/localcovers.js >+++ b/koha-tmpl/opac-tmpl/prog/en/js/localcovers.js >@@ -39,9 +39,9 @@ KOHA.LocalCover = { > if (uselink) { > var a = $("<a />").attr('href', '/cgi-bin/koha/opac-imageviewer.pl?biblionumber=' + $(mydiv).attr("class")); > $(a).append(img); >- $(mydiv).append(a); >+ $(mydiv).empty().append(a); > } else { >- $(mydiv).append(img); >+ $(mydiv).empty().append(img); > } > $(mydiv).children('.no-image').remove(); > } >diff --git a/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js b/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js >index 10a58dd..9142273 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js >+++ b/koha-tmpl/opac-tmpl/prog/en/js/openlibrary.js >@@ -48,7 +48,7 @@ KOHA.OpenLibrary = { > var img = document.createElement("img"); > if (is_opacdetail) { > img.src = book.cover.medium; >- $(this).append(img); >+ $(this).empty().append(img); > $(this).append('<div class="results_summary">' + '<a href="' + book.url + '">Preview</a></div>'); > } else { > img.src = book.cover.medium; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10856
:
20964
|
20965
|
21002
|
21071
|
21136
|
21137
|
21138
|
21211
|
21319
|
21320
|
21321
|
21508
|
21666
|
21670
|
21671
|
21672
|
21673