Bugzilla – Attachment 21744 Details for
Bug 9743
Allow customization for making hold notes required
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9743: Unit test for mandatory hold notes
Bug-9743-Unit-test-for-mandatory-hold-notes.patch (text/plain), 2.48 KB, created by
Marcel de Rooy
on 2013-10-03 09:59:34 UTC
(
hide
)
Description:
Bug 9743: Unit test for mandatory hold notes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-10-03 09:59:34 UTC
Size:
2.48 KB
patch
obsolete
>From 3eebaabda27a8305c1e185c7001ab6a91ce00597 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 6 Mar 2013 14:58:29 +0100 >Subject: [PATCH] Bug 9743: Unit test for mandatory hold notes >Content-Type: text/plain; charset=utf-8 > >Adds three unit tests to Reserves.t > >Test plan: >Run t/db_dependent/Reserves.t. >--- > t/db_dependent/Reserves.t | 27 ++++++++++++++++++++++----- > 1 files changed, 22 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index ad50619..aa13b1e 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -2,7 +2,7 @@ > > use Modern::Perl; > >-use Test::More tests => 17; >+use Test::More tests => 20; > use MARC::Record; > use DateTime::Duration; > >@@ -43,6 +43,7 @@ my $title = 'Silence in the library'; > $bib->append_fields( > MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'), > MARC::Field->new('245', ' ', ' ', a => $title), >+ MARC::Field->new('300', ' ', ' ', a => '2 vols.'), > ); > my ($bibnum, $bibitemnum); > ($bibnum, $title, $bibitemnum) = AddBiblio($bib, ''); >@@ -76,10 +77,7 @@ my $notes = ''; > my $checkitem = undef; > my $found = undef; > >-my @branches = GetBranchesLoop(); >-my $branch = $branches[0][0]{value}; >- >-AddReserve($branch, $borrowernumber, $biblionumber, >+AddReserve('CPL', $borrowernumber, $biblionumber, > $constraint, $bibitems, $priority, $resdate, $expdate, $notes, > $title, $checkitem, $found); > >@@ -266,4 +264,23 @@ is(exists $messages->{ResFound}?1:0, 1, 'AddReturn considers future reserve with > my $letter = ReserveSlip('CPL', $requesters{'CPL'}, $bibnum); > ok(defined($letter), 'can successfully generate hold slip (bug 10949)'); > >+# Tests for mandatory hold notes (bug 9743) >+C4::Context->set_preference('OPACHoldNotes', 1); >+C4::Context->set_preference('OPACMandatoryHoldNotes', '1&2'); >+ >+my $record=GetMarcBiblio($bibnum); >+ >+my $retval= C4::Reserves::GetMandatoryNoteReason($bibnum,$record); >+is($retval, 1, "Mandatory hold notes test 1"); >+ >+C4::Context->set_preference('OPACMandatoryHoldNotes', '4'); >+$retval= C4::Reserves::GetMandatoryNoteReason($bibnum,$record); >+is($retval, 0, "Mandatory hold notes test 2"); >+ >+C4::Context->set_preference('OPACMandatoryHoldNotes', '1&2'); >+C4::Context->set_preference('OPACHoldNotes', 0); >+$retval= C4::Reserves::GetMandatoryNoteReason($bibnum,$record); >+is($retval, 0, "Mandatory hold notes test 3"); >+# End of mandatory hold notes tests (BZ 9743) >+ > $dbh->rollback; >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9743
:
15842
|
15843
|
15910
|
17720
|
17721
|
17722
|
19561
|
19562
|
19563
|
21233
|
21236
|
21240
|
21741
|
21742
|
21743
|
21744
|
34422
|
34526