Bugzilla – Attachment 22325 Details for
Bug 11057
Bootstrap theme: Don't hide language chooser below the fold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold
Bug-11057---Bootstrap-theme-Dont-hide-language-cho.patch (text/plain), 4.21 KB, created by
Jonathan Druart
on 2013-10-23 15:17:26 UTC
(
hide
)
Description:
Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-10-23 15:17:26 UTC
Size:
4.21 KB
patch
obsolete
>From f5c49c547d234a523b94dc8516dd65ae70d35d15 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Sun, 20 Oct 2013 10:39:06 -0700 >Subject: [PATCH] Bug 11057 - Bootstrap theme: Don't hide language chooser > below the fold > >There is a problem with how an active single language is styled, making >the alignment look incorrect. This patch amends the markup and the CSS >to make it look better. This patch does not address the position of the >language menu. > >To test you must have at least one additional single translation >installed. Apply the patch, refresh the page, and confirm that the >display of the active language is improved. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Improved view of current language. No koha-qa errors. > >1) Downloaded a couple of xx-YY-bootstrap.po from >http://translate.koha-community.org/projects/314 >2) Installed sample languages >3) Enable them and opaclanguagesdisplay >4) Checked correct alignment of selected language > >Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >The selected language has not a padding, contrary to others. >Not perfect but it fixes the descripted behavior. >--- > koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 3 +++ > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 4 ++++ > 3 files changed, 9 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/opac.css b/koha-tmpl/opac-tmpl/bootstrap/css/opac.css >index 5b3da1c..a97158f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/opac.css >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/opac.css >@@ -386,6 +386,9 @@ td { > margin-top: .5em; > position: static; > } >+#changelanguage .nav > .active > p { >+ padding: 0 15px; >+} > .table-striped tbody > tr:nth-child(odd) > td, > .table-striped tbody > tr:nth-child(odd) > th { > background-color: #F4F4F4; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >index 2164ee4..c3ce588 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc >@@ -57,9 +57,9 @@ > [% ELSE %] > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.current ) %] >- <li class="morelang"><p>[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</p></li> >+ <li class="active"><p class="navbar-text">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</p></li> > [% ELSE %] >- <li class="morelang"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li> >+ <li><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% languages_loo.rfc4646_subtag %]">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %]</a></li> > [% END %] > [% END # / IF languages_loo.current %] > [% END # / IF ( languages_loo.plural ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/less/opac.less b/koha-tmpl/opac-tmpl/bootstrap/less/opac.less >index 106fb3a..c95d82a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/less/opac.less >+++ b/koha-tmpl/opac-tmpl/bootstrap/less/opac.less >@@ -352,6 +352,10 @@ table, td { > position: static; > } > >+#changelanguage .nav > .active > p { >+ padding : 0 15px; >+} >+ > .table-striped tbody > tr:nth-child(odd) > td, > .table-striped tbody > tr:nth-child(odd) > th { > background-color: #F4F4F4; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11057
:
22008
|
22094
|
22105
|
22108
|
22325
|
38870
|
39289
|
39290