From 4ddee04fc3c2ed6449b627cd055bd04e8a46566d Mon Sep 17 00:00:00 2001 From: Owen Leonard <oleonard@myacpl.org> Date: Wed, 9 Jun 2010 14:41:59 -0400 Subject: [PATCH] Fix for Bug 4868 - Improve controls for cloning and deleting MARC subfields Changes "+" and "-" controls to actively linked images giving better feedback about their clickability and an increased click target area. --- koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css | 1 + .../prog/en/modules/authorities/authorities.tmpl | 4 ++-- .../prog/en/modules/cataloguing/addbiblio.tmpl | 4 ++-- .../intranet-tmpl/prog/img/clone-subfield.png | Bin 0 -> 263 bytes .../intranet-tmpl/prog/img/delete-subfield.png | Bin 0 -> 266 bytes 5 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/img/clone-subfield.png create mode 100644 koha-tmpl/intranet-tmpl/prog/img/delete-subfield.png diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css index 0377cca..f763ad2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css +++ b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css @@ -132,3 +132,4 @@ a.tagnum { .linktools a {margin:0 2px;padding:2px;background-color:#FFF;text-align:center; } .linktools a:first-child { border-bottom: 1px solid #DDD; } .linktools a:hover { background-color: #FFC; } +.subfield_controls { margin : 0 .5em; } \ No newline at end of file diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tmpl index 72b132f..ef85894 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tmpl +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tmpl @@ -708,10 +708,10 @@ function searchauthority() { <!-- TMPL_VAR NAME="marc_value" --> <!-- TMPL_IF NAME="repeatable" --> - <span class="buttonPlus" onclick="CloneSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' -->')">+</span> + <a href="#" onclick="CloneSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' -->'); return false;"><img src="/intranet-tmpl/prog/img/clone-subfield.png" alt="Clone" title="Clone this subfield" /></a> <!-- /TMPL_IF --> <!-- TMPL_UNLESS NAME="mandatory" --> - <span class="buttonMinus" onclick="UnCloneField('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->')">−</span> + <a href="#" onclick="UnCloneField('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->'); return false;"><img src="/intranet-tmpl/prog/img/delete-subfield.png" alt="Delete" title="Delete this subfield" /></a> <!-- /TMPL_UNLESS --> </div> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl index 3e41f04..8c5d499 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl @@ -810,8 +810,8 @@ function unHideSubfield(index,labelindex) { // FIXME :: is it used ? <!-- TMPL_VAR NAME="marc_value" --> <!-- TMPL_IF NAME="repeatable" --> - <span class="buttonPlus" onclick="CloneSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->')">+</span> - <span class="buttonMinus" onclick="UnCloneField('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->')">−</span> + <span class="subfield_controls"><a href="#" onclick="CloneSubfield('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->'); return false;"><img src="/intranet-tmpl/prog/img/clone-subfield.png" alt="Clone" title="Clone this subfield" /></a> + <a href="#" onclick="UnCloneField('subfield<!-- TMPL_VAR NAME='tag' --><!-- TMPL_VAR NAME='subfield' --><!-- TMPL_VAR name="random" -->'); return false;"><img src="/intranet-tmpl/prog/img/delete-subfield.png" alt="Delete" title="Delete this subfield" /></a></span> <!-- /TMPL_IF --> diff --git a/koha-tmpl/intranet-tmpl/prog/img/clone-subfield.png b/koha-tmpl/intranet-tmpl/prog/img/clone-subfield.png new file mode 100644 index 0000000000000000000000000000000000000000..78da39e91f32157290b28fbb6cfa99ab3c240cce GIT binary patch literal 263 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!63?wyl`GbKJOS+@4BLl<w6XvX4FM)i?64!{5 z;QX|b^2DN42FH~Aq*MjZ+{E<Mpwz^a%EFVWHb6x@0X`wFGiT0BOH2C?235b?+d+nv z1o;I61sEK(R(=8U3q4&NLn>}1CAcv&Fdk{pV-RqVU}9io5lLuZp1|P1(8w}l0fP=u zG=b60A|Z{9L!pDghc|#hp<w}&fUyHmY0E+;g@yy$7(xvWhA^-Q+(=0g1?m@c*u<*P jU=YIvF|S1tYA_pvP85@CSE|r<pydpnu6{1-oD!M<@zh3I literal 0 HcmV?d00001 diff --git a/koha-tmpl/intranet-tmpl/prog/img/delete-subfield.png b/koha-tmpl/intranet-tmpl/prog/img/delete-subfield.png new file mode 100644 index 0000000000000000000000000000000000000000..c1e676f2c5130f6ddf22919143a9cb18742b6288 GIT binary patch literal 266 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!63?wyl`GbKJOS+@4BLl<w6XvX4FM)i?64!{5 z;QX|b^2DN42FH~Aq*MjZ+{E<Mpwz^a%EFVWHb6x@0X`wFXN-;i|NlR8=1d^jxuGTt zWLQa%Uoeo%;Gnhg3y@#p>EaktaVsgojhTV*NP`}OfP(}R10#z_LKE`@1_y>l7Kw!n zIzZ6`#ts`7289NL5C#?j7uEn?W@cppV`F9(0Vh^w=8p3`0uCPA8h)N(U~DO14`Fp+ uFjV*<02GwaW93lbVQgSHB)|Y+Ff(`vF%>5LKiLJepTX1B&t;ucLK6TCu|`|~ literal 0 HcmV?d00001 -- 1.7.0.4