Bugzilla – Attachment 2263 Details for
Bug 3916
Batch Modify tool overwrites dropdown fields - no option for "no change"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch proposed for branches.
0001-Bug3916-Batch-Modify-tool-overwrites-branches-fields.patch (text/plain), 1.70 KB, created by
Henri-Damien LAURENT
on 2010-06-23 16:17:02 UTC
(
hide
)
Description:
patch proposed for branches.
Filename:
MIME Type:
Creator:
Henri-Damien LAURENT
Created:
2010-06-23 16:17:02 UTC
Size:
1.70 KB
patch
obsolete
>From b940858d4144dc8b1a54707cb09415cd6a9fd0f9 Mon Sep 17 00:00:00 2001 >From: Henri-Damien LAURENT <henridamien.laurent@biblibre.com> >Date: Wed, 23 Jun 2010 18:15:08 +0200 >Subject: [PATCH] Bug3916 : Batch Modify tool overwrites branches fields > >This was owed to the Item modification construction and the change in GetBranchesLoop behaviour which selects the user branch by default. >Adding a void branch selected >Changing default value to "" >--- > tools/batchMod.pl | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 310624f..abeaf15 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -226,8 +226,8 @@ my $authorised_values_sth = $dbh->prepare("SELECT authorised_value,lib FROM auth > my $branches = GetBranchesLoop(); # build once ahead of time, instead of multiple times later. > > # Adding a default choice, in case the user does not want to modify the branch >-my @nochange_branch = { branchname => '', value => '', selected => 1 }; >-unshift (@$branches, @nochange_branch); >+my $nochange_branch = { branchname => '', value => '', selected => 1 }; >+unshift (@$branches, $nochange_branch); > > my $pref_itemcallnumber = C4::Context->preference('itemcallnumber'); > >@@ -280,8 +280,8 @@ foreach my $tag (sort keys %{$tagslib}) { > foreach my $thisbranch (@$branches) { > push @authorised_values, $thisbranch->{value}; > $authorised_lib{$thisbranch->{value}} = $thisbranch->{branchname}; >- $value = $thisbranch->{value} if $thisbranch->{selected}; > } >+ $value = ""; > } > elsif ( $tagslib->{$tag}->{$subfield}->{authorised_value} eq "itemtypes" ) { > push @authorised_values, "" unless ( $tagslib->{$tag}->{$subfield}->{mandatory} ); >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3916
:
2263
|
7650
|
7669