Bugzilla – Attachment 22804 Details for
Bug 11218
Due notices broken / not generated
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11218: QA follow-up - Fixing some whitespace and a variable declaration
Bug-11218-QA-follow-up---Fixing-some-whitespace-an.patch (text/plain), 3.10 KB, created by
Katrin Fischer
on 2013-11-08 07:39:26 UTC
(
hide
)
Description:
Bug 11218: QA follow-up - Fixing some whitespace and a variable declaration
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-11-08 07:39:26 UTC
Size:
3.10 KB
patch
obsolete
>From 57ae76b60b0d34394adf34f02cadae814fc7a317 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Fri, 8 Nov 2013 08:33:29 +0100 >Subject: [PATCH] Bug 11218: QA follow-up - Fixing some whitespace and a > variable declaration > >Fixing some things the QA script pointed out this morning: > >- whitespace >- variable declaration >--- > t/db_dependent/Circulation.t | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 1a9b8ba..a6a8e15 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -338,7 +338,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > my $barcode2 = 'R00000343'; > my $barcode3 = 'R00000344'; > my $branch = 'MPL'; >- >+ > #Create another record > my $biblio2 = MARC::Record->new(); > my $title2 = 'Something is worng here'; >@@ -347,7 +347,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > MARC::Field->new('245', ' ', ' ', a => $title2), > ); > my ($biblionumber2, $biblioitemnumber2) = AddBiblio($biblio2, ''); >- >+ > #Create third item > AddItem( > { >@@ -375,16 +375,16 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > > my $datedue = AddIssue( $a_borrower, $barcode, $yesterday ); > my $datedue2 = AddIssue( $a_borrower, $barcode2, $two_days_ahead ); >- >+ > my $upcoming_dues; > > diag( "GetUpcomingDueIssues tests" ); >- >+ > for my $i(0..1) { > $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } ); > is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" ); > } >- >+ > #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc. > $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } ); > is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" ); >@@ -397,20 +397,20 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > > # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well > >- my $datedue2 = AddIssue( $a_borrower, $barcode3, $today ); >- >+ my $datedue3 = AddIssue( $a_borrower, $barcode3, $today ); >+ > $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } ); > is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" ); > > $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } ); > is ( scalar ( @$upcoming_dues), 1, "1 item is due today" ); >- >+ > $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } ); > is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" ); >- >+ > $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } ); > is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" ); >- >+ > $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } ); > is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" ); > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11218
:
22795
|
22796
|
22799
|
22802
|
22803
|
22804
|
22823
|
22824
|
22825
|
27531