From e295905e648a1fae2029a3869a1987b64a22a15a Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@biblibre.com>
Date: Fri, 8 Nov 2013 13:40:07 +0100
Subject: [PATCH] Bug 9016: Fix unit tests

The unit tests should insert overdue rules.
+ Fix the doc for GetOverdueMessageTransportTypes
---
 C4/Overdues.pm            |    2 +-
 t/db_dependent/Overdues.t |   10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/C4/Overdues.pm b/C4/Overdues.pm
index 9e60ece..8c0a5ec 100644
--- a/C4/Overdues.pm
+++ b/C4/Overdues.pm
@@ -910,7 +910,7 @@ sub RemoveNotifyLine {
 
     my $message_transport_types = GetOverdueMessageTransportTypes( $branchcode, $categorycode, $letternumber);
 
-    return a arrayref with message_transport_type for given branchcode, categorycode and letternumber(1,2 or 3)
+    return a arrayref with all message_transport_type for given branchcode, categorycode and letternumber(1,2 or 3)
 
 =cut
 sub GetOverdueMessageTransportTypes {
diff --git a/t/db_dependent/Overdues.t b/t/db_dependent/Overdues.t
index 2725565..5e848d1 100644
--- a/t/db_dependent/Overdues.t
+++ b/t/db_dependent/Overdues.t
@@ -21,6 +21,14 @@ $dbh->do(q|
 |);
 
 $dbh->do(q|
+    INSERT INTO overduerules ( branchcode, categorycode ) VALUES
+    ('CPL', 'PT'),
+    ('CPL', 'YA'),
+    ('', 'PT'),
+    ('', 'YA')
+|);
+
+$dbh->do(q|
     INSERT INTO overduerules_transport_types( branchcode, categorycode, letternumber, message_transport_type ) VALUES
     ('CPL', 'PT', 1, 'email'),
     ('CPL', 'PT', 2, 'sms'),
@@ -53,7 +61,7 @@ is_deeply( $mtts, ['sms'], 'GetOverdueMessageTransportTypes: second overdue is b
 $mtts = C4::Overdues::GetOverdueMessageTransportTypes('CPL', 'PT', 3);
 is_deeply( $mtts, ['email'], 'GetOverdueMessageTransportTypes: third overdue is by email for PT (CPL)' );
 
-my $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);
+$mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);
 is_deeply( $mtts, ['email'], 'GetOverdueMessageTransportTypes: first overdue is by email for PT (default)' );
 
 $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 2);
-- 
1.7.10.4