From f9b2a0266a1cb89bf0061d55460383a1e83c5724 Mon Sep 17 00:00:00 2001 From: Mathieu Saby Date: Mon, 11 Nov 2013 22:21:28 +0100 Subject: [PATCH] Bug 10928 - Make orders note visible when receiving an order Content-Type: text/plain; charset="utf-8" notes field is used in biblio table as well as in aqorders table, so results are messed up. The SQL query in C4:Acquisitions:SearchOrders must be changed. This is also the case for timestamp field. This patch change C4:Acquisitions:SearchOrders: - biblio.* is replaced with all fields of biblio table - except for notes, returned as biblionotes and tilmestamp as bibliotimestamp Further improvements could be made later (as suppressing useless biblio.fields from the query). To test : create an order with an order note receive this order, and check the order note is visible in the textarea dedicated to that purpose --- C4/Acquisition.pm | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index aabc0ed..bb604e7 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -1650,7 +1650,8 @@ C<$pending> Finds pending orders. Ignores completed and cancelled orders. C<@results> is an array of references-to-hash with the keys are fields -from aqorders, biblio, biblioitems and aqbasket tables. +from aqorders, biblio, biblioitems and aqbasket tables, except for +biblio.notes returned as biblionotes and biblio.timestamp returned as bibliotimestamp. =cut @@ -1672,7 +1673,17 @@ sub SearchOrders { SELECT aqbasket.basketno, borrowers.surname, borrowers.firstname, - biblio.*, + biblio.frameworkcode, + biblio.author, + biblio.title, + biblio.unititle, + biblio.serial, + biblio.seriestitle, + biblio.copyrightdate, + biblio.datecreated, + biblio.abstract, + biblio.notes as biblionotes, + biblio.timestamp as bibliotimestamp, biblioitems.isbn, biblioitems.biblioitemnumber, aqbasket.closedate, -- 1.7.9.5