From 85b2d7040da3030594138fb735b794ba556f28a6 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 12 Nov 2013 11:05:17 +0100 Subject: [PATCH] Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. --- C4/Serials.pm | 2 +- serials/serials-search.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 1ef8413..da49a2e 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -655,7 +655,7 @@ sub SearchSubscriptions { my $matching_record_ids_for_additional_fields = []; if ( @$additional_fields ) { $matching_record_ids_for_additional_fields = Koha::AdditionalField->get_matching_record_ids({ - fields => $args->{additional_fields}, + fields => $additional_fields, tablename => 'subscription', exact_match => 0, }); diff --git a/serials/serials-search.pl b/serials/serials-search.pl index 50dab9a..6f924a3 100755 --- a/serials/serials-search.pl +++ b/serials/serials-search.pl @@ -76,7 +76,7 @@ if ( $op and $op eq "close" ) { my $additional_fields = Koha::AdditionalField->all( { table => 'subscription', searchable => 1 } ); my $additional_field_filters; for my $field ( @$additional_fields ) { - if ( my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter') ) { + if ( defined ( my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter') ) ) { $additional_field_filters->{ $field->{name} } = $filter_value; } if ( $field->{authorised_value_category} ) { -- 1.7.10.4