View | Details | Raw Unified | Return to bug 7567
Collapse All | Expand All

(-)a/C4/NewsChannels.pm (-56 / +108 lines)
Lines 1-37 Link Here
1
package C4::NewsChannels;
1
package C4::NewsChannels;
2
2
3
# Copyright 2000-2002 Katipo Communications
4
#
5
# This file is part of Koha.
3
# This file is part of Koha.
6
#
4
#
7
# Koha is free software; you can redistribute it and/or modify it under the
5
# Copyright (C) 2000  Katipo Communications
8
# terms of the GNU General Public License as published by the Free Software
6
# Copyright (C) 2013  Mark Tompsett
9
# Foundation; either version 2 of the License, or (at your option) any later
7
#
10
# version.
8
# Koha is free software; you can redistribute it and/or modify it
9
# under the terms of the GNU General Public License as published by
10
# the Free Software Foundation; either version 3 of the License, or
11
# (at your option) any later version.
11
#
12
#
12
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
13
# Koha is distributed in the hope that it will be useful, but
13
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
14
# WITHOUT ANY WARRANTY; without even the implied warranty of
14
# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
15
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16
# GNU General Public License for more details.
15
#
17
#
16
# You should have received a copy of the GNU General Public License along
18
# You should have received a copy of the GNU General Public License
17
# with Koha; if not, write to the Free Software Foundation, Inc.,
19
# along with Koha; if not, see <http://www.gnu.org/licenses>.
18
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
19
20
20
use strict;
21
use warnings;
22
21
22
use Modern::Perl;
23
use C4::Context;
23
use C4::Context;
24
use C4::Dates qw(format_date);
24
use C4::Dates qw(format_date);
25
25
26
use vars qw($VERSION @ISA @EXPORT);
26
use vars qw($VERSION @ISA @EXPORT);
27
27
28
BEGIN { 
28
BEGIN { 
29
    $VERSION = 3.07.00.049;	# set the version for version checking
29
    $VERSION = 3.07.00.049;        # set the version for version checking
30
	@ISA = qw(Exporter);
30
        @ISA = qw(Exporter);
31
	@EXPORT = qw(
31
        @EXPORT = qw(
32
		&GetNewsToDisplay
32
                     &add_opac_new
33
		&add_opac_new &upd_opac_new &del_opac_new &get_opac_new &get_opac_news
33
                     &upd_opac_new
34
	);
34
                     &del_opac_new
35
                     &get_opac_new
36
                     &get_opac_news
37
                     &GetNewsToDisplay
38
                    );
35
}
39
}
36
40
37
=head1 NAME
41
=head1 NAME
Lines 47-76 This module provides the functions needed to mange OPAC and intranet news. Link Here
47
=cut
51
=cut
48
52
49
sub add_opac_new {
53
sub add_opac_new {
50
    my ($title, $new, $lang, $expirationdate, $timestamp, $number) = @_;
54
    my ($href_entry) = @_;
51
    my $dbh = C4::Context->dbh;
55
    my $retval=0;
52
    my $sth = $dbh->prepare("INSERT INTO opac_news (title, new, lang, expirationdate, timestamp, number) VALUES (?,?,?,?,?,?)");
56
53
    $sth->execute($title, $new, $lang, $expirationdate, $timestamp, $number);
57
    if ($href_entry) {
54
    $sth->finish;
58
        my @fields = keys %{$href_entry};
55
    return 1;
59
        my @values = values %{$href_entry};
60
        my $field_string = join ",",@fields;
61
        $field_string = $field_string // q{};
62
        my $values_string = "?," x ($#fields) . "?";
63
64
        my $dbh = C4::Context->dbh;
65
        my $sth = $dbh->prepare("INSERT INTO opac_news ( $field_string ) VALUES ( $values_string );");
66
        $sth->execute(@values);
67
        $retval = 1;
68
    }
69
    return $retval;
56
}
70
}
57
71
58
sub upd_opac_new {
72
sub upd_opac_new {
59
    my ($idnew, $title, $new, $lang, $expirationdate, $timestamp,$number) = @_;
73
    my ($href_entry) = @_;
60
    my $dbh = C4::Context->dbh;
74
    my $retval = 0;
61
    my $sth = $dbh->prepare("
75
62
        UPDATE opac_news SET 
76
    if ($href_entry) {
63
            title = ?,
77
        # take the keys of hash entry and make a list, but...
64
            new = ?,
78
        my @fields = keys %{$href_entry};
65
            lang = ?,
79
        my @values;
66
            expirationdate = ?,
80
        $#values = -1;
67
            timestamp = ?,
81
        my $field_string = q{};
68
            number = ?
82
        foreach my $field_name (@fields) {
69
        WHERE idnew = ?
83
            # exclude idnew
70
    ");
84
            if ( $field_name ne 'idnew' ) {
71
    $sth->execute($title, $new, $lang, $expirationdate, $timestamp,$number,$idnew);
85
                $field_string = $field_string . "$field_name = ?,";
72
    $sth->finish;
86
                push @values,$href_entry->{$field_name};
73
    return 1;
87
            }
88
        }
89
        # put idnew at the end, so we know which record to update
90
        push @values,$href_entry->{'idnew'};
91
        chop $field_string; # remove that excess ,
92
93
        my $dbh = C4::Context->dbh;
94
        my $sth = $dbh->prepare("UPDATE opac_news SET $field_string WHERE idnew = ?;");
95
        $sth->execute(@values);
96
        $retval = 1;
97
    }
98
    return $retval;
74
}
99
}
75
100
76
sub del_opac_new {
101
sub del_opac_new {
Lines 79-85 sub del_opac_new { Link Here
79
        my $dbh = C4::Context->dbh;
104
        my $dbh = C4::Context->dbh;
80
        my $sth = $dbh->prepare("DELETE FROM opac_news WHERE idnew IN ($ids)");
105
        my $sth = $dbh->prepare("DELETE FROM opac_news WHERE idnew IN ($ids)");
81
        $sth->execute();
106
        $sth->execute();
82
        $sth->finish;
83
        return 1;
107
        return 1;
84
    } else {
108
    } else {
85
        return 0;
109
        return 0;
Lines 89-123 sub del_opac_new { Link Here
89
sub get_opac_new {
113
sub get_opac_new {
90
    my ($idnew) = @_;
114
    my ($idnew) = @_;
91
    my $dbh = C4::Context->dbh;
115
    my $dbh = C4::Context->dbh;
92
    my $sth = $dbh->prepare("SELECT * FROM opac_news WHERE idnew = ?");
116
    my $query = q{
117
                  SELECT opac_news.*,branches.branchname,timestamp AS newdate
118
                  FROM opac_news LEFT JOIN branches ON opac_news.branchcode=branches.branchcode
119
                  WHERE opac_news.idnew = ?;
120
                };
121
    my $sth = $dbh->prepare($query);
93
    $sth->execute($idnew);
122
    $sth->execute($idnew);
94
    my $data = $sth->fetchrow_hashref;
123
    my $data = $sth->fetchrow_hashref;
95
    $data->{$data->{'lang'}} = 1 if defined $data->{lang};
124
    $data->{$data->{'lang'}} = 1 if defined $data->{lang};
96
    $data->{expirationdate} = format_date($data->{expirationdate});
125
    $data->{expirationdate} = format_date($data->{expirationdate});
97
    $data->{timestamp}      = format_date($data->{timestamp});
126
    $data->{timestamp}      = format_date($data->{timestamp});
98
    $sth->finish;
127
    if (!defined($data->{branchcode}) || $data->{branchcode} eq '') {
128
        $data->{branchname}     = "All Branches";
129
    }
99
    return $data;
130
    return $data;
100
}
131
}
101
132
102
sub get_opac_news {
133
sub get_opac_news {
103
    my ($limit, $lang) = @_;
134
    my ($limit, $lang, $branchcode) = @_;
135
    my @values;
104
    my $dbh = C4::Context->dbh;
136
    my $dbh = C4::Context->dbh;
105
    my $query = "SELECT *, timestamp AS newdate FROM opac_news";
137
    my $query = q{
106
    if ($lang) {
138
                  SELECT opac_news.*,branches.branchname,timestamp AS newdate
107
        $query.= " WHERE lang = '" .$lang ."' ";
139
                  FROM opac_news LEFT JOIN branches ON opac_news.branchcode=branches.branchcode
140
                };
141
    if ($lang && $branchcode) {
142
        $query.= " WHERE lang=?";
143
        $query .= " AND (opac_news.branchcode=? OR opac_news.branchcode='')";
144
        push @values,$lang;
145
        push @values,$branchcode;
146
    }
147
    elsif ($lang) {
148
        $query.= " WHERE lang=?";
149
        push @values,$lang;
150
    }
151
    elsif ($branchcode) {
152
        $query .= " WHERE (opac_news.branchcode=? OR opac_news.branchcode='')";
153
        push @values,$branchcode;
154
    }
155
    else {
156
       # nothing
108
    }
157
    }
109
    $query.= " ORDER BY timestamp DESC ";
158
    $query.= " ORDER BY timestamp DESC ";
110
    #if ($limit) {
159
    #if ($limit) {
111
    #    $query.= "LIMIT 0, " . $limit;
160
    #    $query.= "LIMIT 0, " . $limit;
112
    #}
161
    #}
113
    my $sth = $dbh->prepare($query);
162
    my $sth = $dbh->prepare($query);
114
    $sth->execute();
163
    $sth->execute(@values);
115
    my @opac_news;
164
    my @opac_news;
116
    my $count = 0;
165
    my $count = 0;
117
    while (my $row = $sth->fetchrow_hashref) {
166
    while (my $row = $sth->fetchrow_hashref) {
118
        if ((($limit) && ($count < $limit)) || (!$limit)) {
167
        if ((($limit) && ($count < $limit)) || (!$limit)) {
119
            $row->{'newdate'} = format_date($row->{'newdate'});
168
            $row->{'newdate'} = format_date($row->{'newdate'});
120
            $row->{'expirationdate'} = format_date($row->{'expirationdate'});
169
            $row->{'expirationdate'} = format_date($row->{'expirationdate'});
170
            $row->{'branchname'}     = "All Branches" if !$row->{'branchcode'};
121
            push @opac_news, $row;
171
            push @opac_news, $row;
122
        }
172
        }
123
        $count++;
173
        $count++;
Lines 127-143 sub get_opac_news { Link Here
127
177
128
=head2 GetNewsToDisplay
178
=head2 GetNewsToDisplay
129
179
130
    $news = &GetNewsToDisplay($lang);
180
    $news = &GetNewsToDisplay($lang,$branch);
131
    C<$news> is a ref to an array which containts
181
    C<$news> is a ref to an array which containts
132
    all news with expirationdate > today or expirationdate is null.
182
    all news with expirationdate > today or expirationdate is null
183
    that is applicable for a given branch.
133
184
134
=cut
185
=cut
135
186
136
sub GetNewsToDisplay {
187
sub GetNewsToDisplay {
137
    my $lang = shift;
188
    my ($lang,$branch) = @_;
138
    my $dbh = C4::Context->dbh;
189
    my $dbh = C4::Context->dbh;
139
    # SELECT *,DATE_FORMAT(timestamp, '%d/%m/%Y') AS newdate
190
    # SELECT *,DATE_FORMAT(timestamp, '%d/%m/%Y') AS newdate
140
    my $query = "
191
    my $query = q{
141
     SELECT *,timestamp AS newdate
192
     SELECT *,timestamp AS newdate
142
     FROM   opac_news
193
     FROM   opac_news
143
     WHERE   (
194
     WHERE   (
Lines 147-159 sub GetNewsToDisplay { Link Here
147
      )
198
      )
148
      AND   `timestamp` <= CURRENT_DATE()
199
      AND   `timestamp` <= CURRENT_DATE()
149
      AND   lang = ?
200
      AND   lang = ?
201
      AND   (branchcode='' OR branchcode = ?)
150
      ORDER BY number
202
      ORDER BY number
151
    ";				# expirationdate field is NOT in ISO format?
203
    };                                # expirationdate field is NOT in ISO format?
152
    my $sth = $dbh->prepare($query);
204
    my $sth = $dbh->prepare($query);
153
    $sth->execute($lang);
205
    $sth->execute($lang,$branch);
154
    my @results;
206
    my @results;
155
    while ( my $row = $sth->fetchrow_hashref ){
207
    while ( my $row = $sth->fetchrow_hashref ){
156
		$row->{newdate} = format_date($row->{newdate});
208
        $row->{newdate} = format_date($row->{newdate});
157
        push @results, $row;
209
        push @results, $row;
158
    }
210
    }
159
    return \@results;
211
    return \@results;
(-)a/installer/data/mysql/kohastructure.sql (+1 lines)
Lines 1636-1641 CREATE TABLE `old_reserves` ( -- this table holds all holds/reserves that have b Link Here
1636
DROP TABLE IF EXISTS `opac_news`;
1636
DROP TABLE IF EXISTS `opac_news`;
1637
CREATE TABLE `opac_news` ( -- data from the news tool
1637
CREATE TABLE `opac_news` ( -- data from the news tool
1638
  `idnew` int(10) unsigned NOT NULL auto_increment, -- unique identifier for the news article
1638
  `idnew` int(10) unsigned NOT NULL auto_increment, -- unique identifier for the news article
1639
  `branchcode` varchar(10) NOT NULL default '', -- branch code used to create branch specific news
1639
  `title` varchar(250) NOT NULL default '', -- title of the news article
1640
  `title` varchar(250) NOT NULL default '', -- title of the news article
1640
  `new` text NOT NULL, -- the body of your news article
1641
  `new` text NOT NULL, -- the body of your news article
1641
  `lang` varchar(25) NOT NULL default '', -- location for the article (koha is the staff client, slip is the circulation receipt and language codes are for the opac)
1642
  `lang` varchar(25) NOT NULL default '', -- location for the article (koha is the staff client, slip is the circulation receipt and language codes are for the opac)
(-)a/installer/data/mysql/updatedatabase.pl (+13 lines)
Lines 7743-7748 if(CheckVersion($DBversion)) { Link Here
7743
    SetVersion($DBversion);
7743
    SetVersion($DBversion);
7744
}
7744
}
7745
7745
7746
$DBversion = "3.13.00.XXX";
7747
if ( CheckVersion($DBversion) ) {
7748
    $dbh->do(q{
7749
        ALTER TABLE opac_news ADD branchcode varchar(10) NOT NULL DEFAULT '';
7750
    });
7751
    $dbh->do(q{
7752
        UPDATE opac_news SET branchcode='';
7753
    });
7754
    print "Upgrade to $DBversion done (Bug 7567: Add branchcode flag to opac_news)\n";
7755
    SetVersion($DBversion);
7756
}
7757
7758
7746
=head1 FUNCTIONS
7759
=head1 FUNCTIONS
7747
7760
7748
=head2 TableExists($table)
7761
=head2 TableExists($table)
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt (-30 / +46 lines)
Lines 56-63 Edit News Item[% ELSE %]Add News Item[% END %][% ELSE %]News[% END %]</div> Link Here
56
56
57
[% IF ( add_form ) %]<div id="doc" class="yui-t7">[% ELSE %]<div id="doc3" class="yui-t2">[% END %]
57
[% IF ( add_form ) %]<div id="doc" class="yui-t7">[% ELSE %]<div id="doc3" class="yui-t2">[% END %]
58
   <div id="bd">
58
   <div id="bd">
59
	<div id="yui-main">
59
        <div id="yui-main">
60
	<div class="yui-b">
60
        <div class="yui-b">
61
61
62
[% UNLESS ( add_form ) %]
62
[% UNLESS ( add_form ) %]
63
<div id="toolbar" class="btn-toolbar">
63
<div id="toolbar" class="btn-toolbar">
Lines 69-99 Edit News Item[% ELSE %]Add News Item[% END %][% ELSE %]News[% END %]</div> Link Here
69
        <form name="add_form" method="post" action="/cgi-bin/koha/tools/koha-news.pl" >
69
        <form name="add_form" method="post" action="/cgi-bin/koha/tools/koha-news.pl" >
70
            <input type="hidden" name="op" value="[% op %]" />
70
            <input type="hidden" name="op" value="[% op %]" />
71
            <input type="hidden" name="id" value="[% id %]" />
71
            <input type="hidden" name="id" value="[% id %]" />
72
			<fieldset class="rows">
72
                        <fieldset class="rows">
73
            <legend>OPAC and Koha news</legend>
73
            <legend>OPAC and Koha news</legend>
74
           <ol> <li>
74
           <ol> <li>
75
            <label for="lang">Display location</label>
75
            <label for="lang">Display location</label>
76
            <select id="lang" name="lang">
76
            <select id="lang" name="lang">
77
                <option value="koha">Librarian interface</option>
77
                <option value=""     [% IF ( new_detail.lang == ""     ) %]selected[% END %]>All</option>
78
                [% IF ( slip ) %]<option value="slip" selected="selected">Slip</option>[% ELSE %]<option value="slip">Slip</option>[% END %]
78
                <option value="koha" [% IF ( new_detail.lang == "koha" ) %]selected[% END %]>Librarian interface</option>
79
                <option value="slip" [% IF ( new_detail.lang == "slip" ) %]selected[% END %]>Slip</option>
79
                [% FOREACH lang_lis IN lang_list %]
80
                [% FOREACH lang_lis IN lang_list %]
80
                    [% IF ( lang_lis.selected ) %]<option value="[% lang_lis.language %]" selected="selected">OPAC ([% lang_lis.language %])</option>[% ELSE %]<option value="[% lang_lis.language %]">OPAC ([% lang_lis.language %])</option>[% END %]
81
                    <option value="[% lang_lis.language %]"
82
                    [% IF ( lang_lis.language == new_detail.lang ) %]selected[% END %]>
83
                        OPAC ([% lang_lis.language %])
84
                    </option>
81
                [% END %]
85
                [% END %]
82
            </select>
86
            </select>
83
            </li>
87
            </li>
84
            <li>
88
            <li>
89
                <label for="branch">Branch: </label>
90
                <select id="branch" name="branch">
91
                    <option value="" [% IF ( new_detail.branchcode == "" ) %]selected[% END %]>All Branches</option>
92
                    [% FOREACH branch_item IN branch_list %]
93
                        <option value="[% branch_item.value.branchcode %]" [% IF ( branch_item.value.branchcode == new_detail.branchcode ) %]selected[% END %]>[% branch_item.value.branchname %]</option>
94
                    [% END %]
95
                </select>
96
            </li>
97
            <li>
85
                <label for="title">Title: </label>
98
                <label for="title">Title: </label>
86
                <input id="title" size="30" type="text" name="title" value="[% new_detail.title %]" />
99
                <input id="title" size="30" type="text" name="title" value="[% new_detail.title %]" />
87
            </li>
100
            </li>
88
            <li>
101
            <li>
89
                <label for="from">Publication date: </label>
102
                <label for="from">Publication date: </label>
90
                <input id="from" type="text" name="timestamp" size="15" value="[% new_detail.timestamp %]" class="datepickerfrom" />
103
                <input id="from" type="text" name="timestamp" size="15" value="[% new_detail.timestamp %]" class="datepickerfrom" />
91
				<div class="hint">[% INCLUDE 'date-format.inc' %]</div>
104
                                <div class="hint">[% INCLUDE 'date-format.inc' %]</div>
92
            </li>
105
            </li>
93
            <li>
106
            <li>
94
                <label for="to">Expiration date: </label>
107
                <label for="to">Expiration date: </label>
95
                <input id="to" type="text" name="expirationdate" size="15" value="[% new_detail.expirationdate %]" class="datepickerto" />
108
                <input id="to" type="text" name="expirationdate" size="15" value="[% new_detail.expirationdate %]" class="datepickerto" />
96
				<div class="hint">[% INCLUDE 'date-format.inc' %]</div>
109
                                <div class="hint">[% INCLUDE 'date-format.inc' %]</div>
97
            </li>
110
            </li>
98
            <li>
111
            <li>
99
                <label for="number">Appear in position: </label>
112
                <label for="number">Appear in position: </label>
Lines 106-112 Edit News Item[% ELSE %]Add News Item[% END %][% ELSE %]News[% END %]</div> Link Here
106
            <li><label for="new">News: </label>
119
            <li><label for="new">News: </label>
107
            <textarea name="new" id="new"  cols="75" rows="10">[% new_detail.new %]</textarea></li>
120
            <textarea name="new" id="new"  cols="75" rows="10">[% new_detail.new %]</textarea></li>
108
            </ol>
121
            </ol>
109
			</fieldset>
122
                        </fieldset>
110
  
123
  
111
                <fieldset class="action"><input class="button" type="submit" value="Submit" /> <a class="cancel" href="/cgi-bin/koha/tools/koha-news.pl">Cancel</a></fieldset>
124
                <fieldset class="action"><input class="button" type="submit" value="Submit" /> <a class="cancel" href="/cgi-bin/koha/tools/koha-news.pl">Cancel</a></fieldset>
112
        </form>
125
        </form>
Lines 115-131 Edit News Item[% ELSE %]Add News Item[% END %][% ELSE %]News[% END %]</div> Link Here
115
        <form name="add_form" method="post" action="/cgi-bin/koha/tools/koha-news.pl" >
128
        <form name="add_form" method="post" action="/cgi-bin/koha/tools/koha-news.pl" >
116
            <label for="lang">Display location:</label>
129
            <label for="lang">Display location:</label>
117
            <select name="lang" id="lang">
130
            <select name="lang" id="lang">
118
            <option value="">All</option>
131
                <option value="" [% IF ( lang == "" ) %]selected[% END %]>All</option>
119
            <option value="koha">Librarian interface</option>
132
                <option value="koha" [% IF ( lang == "koha" ) %]selected[% END %]>Librarian interface</option>
120
	    <option value="slip">Slip</option>
133
                <option value="slip" [% IF ( lang == "slip" ) %]selected[% END %]>Slip</option>
121
                [% FOREACH lang_lis IN lang_list %]
134
                [% FOREACH lang_lis IN lang_list %]
122
                    [% IF ( lang_lis.selected ) %]
135
                    <option value="[% lang_lis.language %]" [% IF ( lang_lis.language == lang ) %]selected[% END %]>OPAC ([% lang_lis.language %])</option>
123
                        <option value="[% lang_lis.language %]" selected="selected">
136
                [% END %]
124
                    [% ELSE %]
137
            </select>
125
                        <option value="[% lang_lis.language %]">
138
            <label for="branch">Branch: </label>
126
                    [% END %]
139
            <select id="branch" name="branch">
127
                        OPAC ([% lang_lis.language %])
140
                <option value="" [% IF ( branchcode == "" ) %]selected[% END %]>All Branches</option>
128
                    </option>
141
                [% FOREACH branch_item IN branch_list %]
142
                    <option value="[% branch_item.value.branchcode %]" [% IF ( branch_item.value.branchcode == branchcode ) %]selected[% END %]>[% branch_item.value.branchname %]</option>
129
                [% END %]
143
                [% END %]
130
            </select>
144
            </select>
131
            <input type="submit" class="button" value="Filter" />
145
            <input type="submit" class="button" value="Filter" />
Lines 137-142 Edit News Item[% ELSE %]Add News Item[% END %][% ELSE %]News[% END %]</div> Link Here
137
                   <thead> <tr>
151
                   <thead> <tr>
138
                        <th>&nbsp;</th>
152
                        <th>&nbsp;</th>
139
                        <th>Location</th>
153
                        <th>Location</th>
154
                        <th>Branch</th>
140
                        <th>Number</th>
155
                        <th>Number</th>
141
                        <th>Creation date</th>
156
                        <th>Creation date</th>
142
                        <th>Expiration date</th>
157
                        <th>Expiration date</th>
Lines 153-169 Edit News Item[% ELSE %]Add News Item[% END %][% ELSE %]News[% END %]</div> Link Here
153
                            <td>
168
                            <td>
154
                                <input type="checkbox" name="ids" value="[% opac_new.idnew %]" />
169
                                <input type="checkbox" name="ids" value="[% opac_new.idnew %]" />
155
                            </td>
170
                            </td>
156
                            <td>[% IF ( opac_new.lang == 'koha' ) %]
171
                            <td>[% SWITCH opac_new.lang %]
157
			            Librarian interface
172
                                [%   CASE 'koha' %]
158
                                 [% ELSE %]
173
                                    Librarian interface
159
                                    [% IF ( opac_new.lang == 'slip' ) %]
174
                                [%   CASE 'slip' %]
160
				        Slip
175
                                    Slip
161
                                    [% ELSE %]
176
                                [%   CASE '' %]
162
                                        OPAC
177
                                    All
163
				    [% END %]
178
                                [%   CASE %]
164
				 [% END %]
179
                                    OPAC ([% opac_new.lang %])
165
                             </td>
180
                                [% END %]
166
181
                            </td>
182
                            <td>[% opac_new.branchname %]</td>
167
                            <td>[% opac_new.number %]</td>
183
                            <td>[% opac_new.number %]</td>
168
                            <td>[% opac_new.newdate %]</td>
184
                            <td>[% opac_new.newdate %]</td>
169
                            <td>[% opac_new.expirationdate %] [% IF ( opac_new.expired ) %](<span class="expired">expired</span>)[% END %]</td>
185
                            <td>[% opac_new.expirationdate %] [% IF ( opac_new.expired ) %](<span class="expired">expired</span>)[% END %]</td>
(-)a/mainpage.pl (-1 / +5 lines)
Lines 42-48 my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user( Link Here
42
    }
42
    }
43
);
43
);
44
44
45
my $all_koha_news   = &GetNewsToDisplay("koha");
45
my $homebranch;
46
if (C4::Context->userenv) {
47
    $homebranch = C4::Context->userenv->{'branch'};
48
}
49
my $all_koha_news   = &GetNewsToDisplay("koha",$homebranch);
46
my $koha_news_count = scalar @$all_koha_news;
50
my $koha_news_count = scalar @$all_koha_news;
47
51
48
$template->param(
52
$template->param(
(-)a/opac/opac-main.pl (-2 / +6 lines)
Lines 21-27 use warnings; Link Here
21
use CGI;
21
use CGI;
22
use C4::Auth;    # get_template_and_user
22
use C4::Auth;    # get_template_and_user
23
use C4::Output;
23
use C4::Output;
24
use C4::NewsChannels;    # get_opac_news
24
use C4::NewsChannels;    # GetNewsToDisplay
25
use C4::Languages qw(getTranslatedLanguages accept_language);
25
use C4::Languages qw(getTranslatedLanguages accept_language);
26
use C4::Koha qw( GetDailyQuote );
26
use C4::Koha qw( GetDailyQuote );
27
27
Lines 48-54 $template->param( Link Here
48
# use cookie setting for language, bug default to syspref if it's not set
48
# use cookie setting for language, bug default to syspref if it's not set
49
my ($theme, $news_lang, $availablethemes) = C4::Templates::themelanguage(C4::Context->config('opachtdocs'),'opac-main.tt','opac',$input);
49
my ($theme, $news_lang, $availablethemes) = C4::Templates::themelanguage(C4::Context->config('opachtdocs'),'opac-main.tt','opac',$input);
50
50
51
my $all_koha_news   = &GetNewsToDisplay($news_lang);
51
my $homebranch;
52
if (C4::Context->userenv) {
53
    $homebranch = C4::Context->userenv->{'branch'};
54
}
55
my $all_koha_news   = &GetNewsToDisplay($news_lang,$homebranch);
52
my $koha_news_count = scalar @$all_koha_news;
56
my $koha_news_count = scalar @$all_koha_news;
53
57
54
my $quote = GetDailyQuote();   # other options are to pass in an exact quote id or select a random quote each pass... see perldoc C4::Koha
58
my $quote = GetDailyQuote();   # other options are to pass in an exact quote id or select a random quote each pass... see perldoc C4::Koha
(-)a/t/NewsChannels.t (-14 lines)
Lines 1-14 Link Here
1
#!/usr/bin/perl
2
#
3
# This Koha test module is a stub!  
4
# Add more tests here!!!
5
6
use strict;
7
use warnings;
8
9
use Test::More tests => 1;
10
11
BEGIN {
12
        use_ok('C4::NewsChannels');
13
}
14
(-)a/t/db_dependent/NewsChannels.t (+120 lines)
Line 0 Link Here
1
#!/usr/bin/perl
2
#
3
# This Koha test module is a stub!  
4
# Add more tests here!!!
5
6
use Modern::Perl;
7
use C4::Dates qw(format_date);
8
use C4::Branch qw(GetBranchName);
9
use Test::More tests => 8;
10
11
BEGIN {
12
        use_ok('C4::NewsChannels');
13
}
14
15
16
my $dbh = C4::Context->dbh;
17
18
# Start transaction
19
$dbh->{AutoCommit} = 0;
20
$dbh->{RaiseError} = 1;
21
22
# Add LIB1, if it doesn't exist.
23
my $addbra = 'LIB1';
24
$dbh->do(q{
25
    INSERT INTO branches (branchcode,branchname) VALUES (?,?)
26
          }, undef,      ($addbra,   "$addbra branch")
27
        ) unless GetBranchName($addbra);
28
29
# Test add_opac_new
30
my $timestamp = '2000-01-01';
31
my $hashref_entry1 = {
32
  'title'          => 'News Title',
33
  'new'            => '<p>We have some exciting news!</p>',
34
  'lang'           => '',
35
  'timestamp'      => $timestamp,
36
  'expirationdate' => '2999-12-30',
37
  'number'         => 1,
38
  'branchcode'     => 'LIB1',
39
                  };
40
my $rv = add_opac_new( $hashref_entry1 );
41
ok($rv==1,"Successfully added the first dummy news item!");
42
43
my $hashref_entry2 = {
44
  "title"          => 'News Title2',
45
  "new"            => '<p>We have some exciting news!</p>',
46
  "lang"           => '',
47
  "timestamp"      => $timestamp,
48
  "expirationdate" => '2999-12-31',
49
  "number"         => 1,
50
  "branchcode"     => 'LIB1',
51
                     };
52
$rv = add_opac_new( $hashref_entry2 );
53
ok($rv==1,"Successfully added the second dummy news item!");
54
55
# We need to determine the idnew in a non-MySQLism way.
56
# This should be good enough.
57
my $sth = $dbh->prepare(q{
58
  SELECT idnew from opac_news
59
  WHERE timestamp='2000-01-01' AND 
60
        expirationdate='2999-12-30' AND
61
        branchcode='LIB1';
62
                        });
63
$sth->execute();
64
my $idnew1 = $sth->fetchrow;
65
$sth = $dbh->prepare(q{
66
  SELECT idnew from opac_news
67
  WHERE timestamp='2000-01-01' AND 
68
        expirationdate='2999-12-31' AND
69
        branchcode='LIB1';
70
                        });
71
$sth->execute();
72
my $idnew2 = $sth->fetchrow;
73
74
# Test upd_opac_new
75
$hashref_entry2->{new} = '<p>Update! There is no news!</p>';
76
$hashref_entry2->{idnew} = $idnew2;
77
$rv = upd_opac_new($hashref_entry2);
78
ok($rv==1,"Successfully updated second dummy news item!");
79
80
# Test get_opac_new (single news item)
81
$hashref_entry1->{timestamp} =
82
  format_date( $hashref_entry1->{timestamp} );
83
$hashref_entry1->{expirationdate} =
84
  format_date( $hashref_entry1->{expirationdate} );
85
$hashref_entry2->{timestamp} =
86
  format_date( $hashref_entry2->{timestamp} );
87
$hashref_entry2->{expirationdate} =
88
  format_date( $hashref_entry2->{expirationdate} );
89
my $hashref_check = get_opac_new($idnew1);
90
my $failure = 0;
91
foreach my $key (keys %{$hashref_entry1}) {
92
    if ($hashref_entry1->{$key} ne $hashref_check->{$key}) {
93
        $failure = 1;
94
        print STDERR "\nKey mismatch: " . $hashref_entry1->{$key} . " vs ";
95
        print STDERR $hashref_check->{$key} . "\n";
96
    }
97
}
98
ok($failure==0,"Successfully tested get_opac_new id1!");
99
100
# Test get_opac_new (single news item)
101
$hashref_check = get_opac_new($idnew2);
102
$failure = 0;
103
foreach my $key (keys %{$hashref_entry2}) {
104
    if ($hashref_entry2->{$key} ne $hashref_check->{$key}) {
105
        $failure = 1;
106
        print STDERR "\nKey mismatch: " . $hashref_entry1->{$key} . " vs ";
107
        print STDERR $hashref_check->{$key} . "\n";
108
    }
109
}
110
ok($failure==0,"Successfully tested get_opac_new id2!");
111
112
# Test get_opac_news (multiple news items)
113
my ($opac_news_count, $arrayref_opac_news) = get_opac_news(0,'','LIB1');
114
ok($opac_news_count>=2,"Successfully tested get_opac_news for LIB1!");
115
116
# Test GetNewsToDisplay
117
($opac_news_count, $arrayref_opac_news) = GetNewsToDisplay('','LIB1');
118
ok($opac_news_count>=2,"Successfully tested GetNewsToDisplay for LIB1!");
119
120
$dbh->rollback;
(-)a/tools/koha-news.pl (-7 / +32 lines)
Lines 32-37 use C4::Output; Link Here
32
use C4::NewsChannels;
32
use C4::NewsChannels;
33
use C4::Languages qw(getTranslatedLanguages);
33
use C4::Languages qw(getTranslatedLanguages);
34
use Date::Calc qw/Date_to_Days Today/;
34
use Date::Calc qw/Date_to_Days Today/;
35
use C4::Branch qw/GetBranches/;
35
36
36
my $cgi = new CGI;
37
my $cgi = new CGI;
37
38
Lines 42-47 my $expirationdate = format_date_in_iso($cgi->param('expirationdate')); Link Here
42
my $timestamp      = format_date_in_iso($cgi->param('timestamp'));
43
my $timestamp      = format_date_in_iso($cgi->param('timestamp'));
43
my $number         = $cgi->param('number');
44
my $number         = $cgi->param('number');
44
my $lang           = $cgi->param('lang');
45
my $lang           = $cgi->param('lang');
46
my $branchcode     = $cgi->param('branch');
47
my $hashref_entry;
45
48
46
my $new_detail = get_opac_new($id);
49
my $new_detail = get_opac_new($id);
47
50
Lines 67-75 foreach my $language ( @$tlangs ) { Link Here
67
      };
70
      };
68
}
71
}
69
72
70
$template->param( lang_list => \@lang_list );
73
my $branches = GetBranches;
71
74
72
my $op = $cgi->param('op');
75
$template->param( lang_list   => \@lang_list,
76
                  branch_list => $branches,
77
                  branchcode => $branchcode );
78
79
my $op = $cgi->param('op') // '';
73
80
74
if ( $op eq 'add_form' ) {
81
if ( $op eq 'add_form' ) {
75
    $template->param( add_form => 1 );
82
    $template->param( add_form => 1 );
Lines 86-96 if ( $op eq 'add_form' ) { Link Here
86
    }
93
    }
87
}
94
}
88
elsif ( $op eq 'add' ) {
95
elsif ( $op eq 'add' ) {
89
    add_opac_new( $title, $new, $lang, $expirationdate, $timestamp, $number );
96
    $hashref_entry = {
97
                    "title"          => $title,
98
                    "new"            => $new,
99
                    "lang"           => $lang,
100
                    "timestamp"      => $timestamp,
101
                    "expirationdate" => $expirationdate,
102
                    "number"         => $number,
103
                    "branchcode"     => $branchcode,
104
                  };
105
    add_opac_new( $hashref_entry );
90
    print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl");
106
    print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl");
91
}
107
}
92
elsif ( $op eq 'edit' ) {
108
elsif ( $op eq 'edit' ) {
93
    upd_opac_new( $id, $title, $new, $lang, $expirationdate, $timestamp ,$number );
109
    $hashref_entry = {
110
                    "idnew"          => $id,
111
                    "title"          => $title,
112
                    "new"            => $new,
113
                    "lang"           => $lang,
114
                    "timestamp"      => $timestamp,
115
                    "expirationdate" => $expirationdate,
116
                    "number"         => $number,
117
                    "branchcode"     => $branchcode,
118
                  };
119
    upd_opac_new( $hashref_entry );
94
    print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl");
120
    print $cgi->redirect("/cgi-bin/koha/tools/koha-news.pl");
95
}
121
}
96
elsif ( $op eq 'del' ) {
122
elsif ( $op eq 'del' ) {
Lines 101-107 elsif ( $op eq 'del' ) { Link Here
101
127
102
else {
128
else {
103
129
104
    my ( $opac_news_count, $opac_news ) = &get_opac_news( undef, $lang );
130
    my ( $opac_news_count, $opac_news ) = &get_opac_news( 0, $lang, $branchcode );
105
    
131
    
106
    foreach my $new ( @$opac_news ) {
132
    foreach my $new ( @$opac_news ) {
107
        next unless $new->{'expirationdate'};
133
        next unless $new->{'expirationdate'};
Lines 113-121 else { Link Here
113
    }
139
    }
114
    
140
    
115
    $template->param(
141
    $template->param(
116
        $lang           => 1,
117
        opac_news       => $opac_news,
142
        opac_news       => $opac_news,
118
        opac_news_count => $opac_news_count,
143
        opac_news_count => $opac_news_count,
119
		);
144
		);
145
    $template->param( lang => $lang );
120
}
146
}
121
output_html_with_http_headers $cgi, $cookie, $template->output;
147
output_html_with_http_headers $cgi, $cookie, $template->output;
122
- 

Return to bug 7567