Bugzilla – Attachment 23002 Details for
Bug 6837
When AllowOnShelfHolds is OFF then holds on records with available items should not be possible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Supersedes previous patch. Fixes original problem with out extra SysPref
0001-Bug-6837-When-AllowOnShelfHolds-is-OFF-then-holds-on.patch (text/plain), 3.45 KB, created by
Barry Cannon
on 2013-11-18 16:44:46 UTC
(
hide
)
Description:
Supersedes previous patch. Fixes original problem with out extra SysPref
Filename:
MIME Type:
Creator:
Barry Cannon
Created:
2013-11-18 16:44:46 UTC
Size:
3.45 KB
patch
obsolete
>From 8ff46c33e6e1b3e4a59ef2956404a6ba6ba30ca2 Mon Sep 17 00:00:00 2001 >From: Barry Cannon <barry@oslo.ie> >Date: Mon, 18 Nov 2013 16:33:45 +0000 >Subject: [PATCH] Bug 6837 - When AllowOnShelfHolds is OFF then holds on > records with available items should not be possible > >This patch corrects this bug. Allows holds when systempref is set to "Allow", disallows when set to "Don't Allow". >--- > koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc | 4 ---- > koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt | 4 ---- > koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt | 4 ---- > 3 files changed, 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc >index 0f16f3a..634fb95 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc >@@ -4,10 +4,6 @@ > [% IF ( RequestOnOpac ) %] > [% IF ( AllowOnShelfHolds ) %] > <li><a class="reserve" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% biblionumber %]">Place hold</a></li> >- [% ELSE %] >- [% IF ( ItemsIssued ) %] >- <li><a class="reserve" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% biblionumber %]">Place hold</a></li> >- [% END %] > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt >index 2010cee..83d4a61 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt >@@ -275,10 +275,6 @@ function highlightOn() { > [% IF ( opacuserlogin ) %] > [% IF ( AllowOnShelfHolds ) %] > <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% GROUP_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue--> >- [% ELSE %] >- [% IF ( GROUP_RESULT.itemsissued ) %] >- <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% GROUP_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue--> >- [% END %] > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >index 9235b2b..5598ca1 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt >@@ -669,10 +669,6 @@ $(document).ready(function(){ > [% IF ( opacuserlogin ) %] > [% IF ( AllowOnShelfHolds ) %] > <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue--> >- [% ELSE %] >- [% IF ( SEARCH_RESULT.itemsissued ) %] >- <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue--> >- [% END %] > [% END %] > [% END %] > [% END %] >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6837
:
5285
|
22847
|
23002
|
23003
|
23162