From eff3f92716c7c8aa9093190331617f1837fdee1b Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 18 Nov 2013 19:04:56 -0300 Subject: [PATCH] Bug 11269 - Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search To test: - Run prove -v t/db_dependent/Search.t - There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field. - Apply the patch. - Those warnings are gone. Regards To+ Signed-off-by: Liz Rea Tests now pass --- C4/Search.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/C4/Search.pm b/C4/Search.pm index c9f2560..dd844e3 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1681,7 +1681,9 @@ sub searchResults { while ( ( my $column ) = $sth2->fetchrow ) { my ( $tagfield, $tagsubfield ) = &GetMarcFromKohaField( "items." . $column, "" ); - $subfieldstosearch{$column} = $tagsubfield; + if ( defined $tagsubfield ) { + $subfieldstosearch{$column} = $tagsubfield; + } } # handle which records to actually retrieve -- 1.7.9.5