Bugzilla – Attachment 23043 Details for
Bug 11214
Allow create routing list in serial collection page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11214 - Allow create routing list in serial collection page
Bug-11214---Allow-create-routing-list-in-serial-co.patch (text/plain), 3.07 KB, created by
Liz Rea
on 2013-11-19 22:05:34 UTC
(
hide
)
Description:
Bug 11214 - Allow create routing list in serial collection page
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2013-11-19 22:05:34 UTC
Size:
3.07 KB
patch
obsolete
>From 1f1efe6a2a2c63bede50aba986e4c0c112980f70 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Thu, 7 Nov 2013 10:22:49 +0100 >Subject: [PATCH] Bug 11214 - Allow create routing list in serial collection > page >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When a subscription has no routing list yet, the page serials/subscription-detail.pl shows in left menu : "Create routing list". >In serials/serials-collection.pl page, the link in table is always "Edit routing list", even when there is no routing list. > >This patch adds a conditionnal link "Edit routing list"/"Create routing list" into serials/serials-collection.pl page. > >Test plan : >- Create a subscription n°1 without routing list and a subscription n°2 with a routing list >- Go to serials/serials-collection.pl of subscription n°1 >=> You see "Create routing list" link >- Click on link >=> You see "Create routing list for" >- Go to serials/serials-collection.pl of subscription n°2 >=> You see "Edit routing list" link >- Click on link >=> You see "Edit routing list for ..." > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >Functional and automated tests pass. Passes koha-qa.pl. >--- > .../prog/en/modules/serials/serials-collection.tt | 6 +++++- > serials/serials-collection.pl | 1 + > 2 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index bd94f71..060ecaf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -140,7 +140,11 @@ $(document).ready(function() { > [% IF ( routing && CAN_user_serials_routing ) %] > <td> > [% UNLESS subscription.closed %] >- <a href="/cgi-bin/koha/serials/routing.pl?subscriptionid=[% subscription.subscriptionid %]">Edit routing list</a> >+ [% IF ( subscription.hasRouting ) %] >+ <a href="/cgi-bin/koha/serials/routing.pl?subscriptionid=[% subscription.subscriptionid %]">Edit routing list</a> >+ [% ELSE %] >+ <a href="/cgi-bin/koha/serials/routing.pl?subscriptionid=[% subscription.subscriptionid %]&op=new">Create routing list</a> >+ [% END %] > [% END %] > </td> > [% END %] >diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl >index bb1967b..ba97163 100755 >--- a/serials/serials-collection.pl >+++ b/serials/serials-collection.pl >@@ -128,6 +128,7 @@ if (@subscriptionid){ > my $numberpattern = C4::Serials::Numberpattern::GetSubscriptionNumberpattern($subs->{numberpattern}); > $subs->{frequency} = $frequency; > $subs->{numberpattern} = $numberpattern; >+ $subs->{'hasRouting'} = check_routing($subscriptionid); > push @$subscriptiondescs,$subs; > my $tmpsubscription= GetFullSubscription($subscriptionid); > @subscriptioninformation=(@$tmpsubscription,@subscriptioninformation); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11214
:
22763
|
23043
|
23127