Bugzilla – Attachment 23123 Details for
Bug 11286
Bug 10602 prevents to create new subfields in authorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks
PASSED-QA-Bug-11286-FIX-Add-a-new-subfield-to-an-a.patch (text/plain), 2.46 KB, created by
Katrin Fischer
on 2013-11-24 22:21:15 UTC
(
hide
)
Description:
[PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-11-24 22:21:15 UTC
Size:
2.46 KB
patch
obsolete
>From ac948f748603f860846f53d0511aea4aa6a7cf68 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 22 Nov 2013 10:42:42 +0100 >Subject: [PATCH] [PASSED QA] Bug 11286: FIX Add a new subfield to an authority > frameworks > >Bug 10602 introduces a bug when adding a new subfield to an authority >framework. A new parameter is added in a sql query but the placeholder >is missing. > >Test plan: >- edit an authority framework >- add a new subfield >- save >- boom! >DBD::mysql::st execute failed: called with 16 bind variables when 15 are >needed at >/home/home/src/admin/auth_subfields_structure.pl line 454. >- apply the patch and try again > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Work as described. No koha-qa errors > >Tested trying to add subfield to 100, 2 for example. >Without patch silently fails (but error is logged) >With patch subfield creation or elimination is fine > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >One line fix for a bad bug. Confirmed the bug on master and >the fix. Passes all tests and QA script. >--- > admin/auth_subfields_structure.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/auth_subfields_structure.pl b/admin/auth_subfields_structure.pl >index d9f10b4..fb0e59c 100755 >--- a/admin/auth_subfields_structure.pl >+++ b/admin/auth_subfields_structure.pl >@@ -388,7 +388,7 @@ if ($op eq 'add_form') { > # my $sth=$dbh->prepare("replace auth_subfield_structure (authtypecode,tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,frameworkcode,value_builder,hidden,isurl) > # values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"); > my $sth_insert = $dbh->prepare("insert into auth_subfield_structure (authtypecode,tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,frameworkcode,value_builder,hidden,isurl,defaultvalue) >- values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"); >+ values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"); > my $sth_update = $dbh->prepare("update auth_subfield_structure set authtypecode=?, tagfield=?, tagsubfield=?, liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?, seealso=?, authorised_value=?, frameworkcode=?, value_builder=?, hidden=?, isurl=?, defaultvalue=? > where authtypecode=? and tagfield=? and tagsubfield=?"); > my @tagsubfield = $input->param('tagsubfield'); >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11286
:
23077
|
23121
| 23123