Bugzilla – Attachment 23262 Details for
Bug 11249
Add db indexes on borrowers names
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11249 - Add db indexes on borrowers names
PASSED-QA-Bug-11249---Add-db-indexes-on-borrowers-.patch (text/plain), 3.21 KB, created by
Katrin Fischer
on 2013-12-03 12:41:35 UTC
(
hide
)
Description:
[PASSED QA] Bug 11249 - Add db indexes on borrowers names
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-12-03 12:41:35 UTC
Size:
3.21 KB
patch
obsolete
>From 8c17e2d1326ce07f9b788c2ce3de69aeac0378d1 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Thu, 14 Nov 2013 14:29:51 +0100 >Subject: [PATCH] [PASSED QA] Bug 11249 - Add db indexes on borrowers names > >The borrowers search is by default on columns surname, firstname, othernames and cardnumber. >(See C4::Members::_express_member_find). >Addind db indexes will really increase the query speed. > >This patch adds bd indexes on surname, firstname, othernames (cardnumber has already an index). >Those indexes must be defined with a size because columns are mediumtext. > >Test plan : >Test with mysql client : >mysql> explain select * from borrowers where surname like 'A%'; >+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+ >| id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | >+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+ >| 1 | SIMPLE | borrowers | range | surname_idx | surname_idx | 767 | NULL | 395 | Using where | >+----+-------------+-----------+-------+---------------+-------------+---------+------+------+-------------+ >=> key show the index is used > >Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described, changes from updatedatabase and in kohastructure match. >I think deletedborrowers can be left out, as it's not queried when doing >patron searches. Patron deletes still work as expected. >--- > installer/data/mysql/kohastructure.sql | 3 +++ > installer/data/mysql/updatedatabase.pl | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 07160c8..e60b61e 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -271,6 +271,9 @@ CREATE TABLE `borrowers` ( -- this table includes information about your patrons > KEY `branchcode` (`branchcode`), > KEY `userid` (`userid`), > KEY `guarantorid` (`guarantorid`), >+ KEY `surname_idx` (`surname`(255)), >+ KEY `firstname_idx` (`firstname`(255)), >+ KEY `othernames_idx` (`othernames`(255)), > CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`), > CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8; >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index a9bfbbf..780735c 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -7778,6 +7778,18 @@ if(CheckVersion($DBversion)) { > SetVersion($DBversion); > } > >+$DBversion = "3.15.00.XXX"; >+if(CheckVersion($DBversion)) { >+ $dbh->do(q{ >+ ALTER TABLE `borrowers` >+ ADD KEY `surname_idx` (`surname`(255)), >+ ADD KEY `firstname_idx` (`firstname`(255)), >+ ADD KEY `othernames_idx` (`othernames`(255)) >+ }); >+ print "Upgrade to $DBversion done (Bug 11249 - Add db indexes on borrowers names)\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11249
:
22930
|
23001
|
23223
| 23262 |
74372