From 16066725c3c30e009b8c7b22e15d84e858f964a7 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 12 Nov 2013 15:31:56 +0100 Subject: [PATCH] Bug 11225: \n in translation strings should be removed Some strings in the serials module contain linebreaks \n that cause problems in translation. Test plan: - Update your po file - Verify that strings in serials/subscription-add.tt and serials/subscription-numberpatterns.tt are present and don't contain "\n" character. Signed-off-by: Katrin Fischer Template only change, passes all tests and QA script. Updated po files now contain only the strings and no line breaks. Signed-off-by: Kyle M Hall No regressions found. Passes koha-qa.pl and xt. --- .../prog/en/modules/serials/subscription-add.tt | 8 ++++---- .../modules/serials/subscription-numberpatterns.tt | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt index 713b3b1..18f8962 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt @@ -256,24 +256,24 @@ function testPredictionPattern() { var error = 0; var error_msg = ""; if(frequencyid == undefined || frequencyid == ""){ - error_msg += _("- Frequency is not defined\n"); + error_msg += _("- Frequency is not defined") + "\n"; error ++; } acquidate = $("#acqui_date").val(); if(acquidate == undefined || acquidate == ""){ - error_msg += _("- First publication date is not defined\n"); + error_msg += _("- First publication date is not defined") + "\n"; error ++; } [% IF (more_than_one_serial) %] var nextacquidate = $("#nextacquidate").val(); if(nextacquidate == undefined || nextacquidate == ""){ - error_msg += _("- Next issue publication date is not defined\n"); + error_msg += _("- Next issue publication date is not defined") + "\n"; error ++; } [% END %] if(error){ - alert(_("Cannot test prediction pattern for the following reason(s):\n\n") + alert(_("Cannot test prediction pattern for the following reason(s):") + "\n\n" + error_msg); return false; } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt index 686cdc8..953882f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt @@ -11,16 +11,16 @@ var error = 0; var error_msg = ""; if(frequencyid == undefined || frequencyid == "") { - error_msg += _("- Frequency is not defined\n"); + error_msg += _("- Frequency is not defined") + "\n"; error ++; } if(firstacquidate == undefined || firstacquidate == "") { - error_msg += _("- First publication date is not defined\n"); + error_msg += _("- First publication date is not defined") + "\n"; error ++; } if(error){ - alert(_("Cannot test prediction pattern for the following reason(s):\n\n") + alert(_("Cannot test prediction pattern for the following reason(s):") + "\n\n" + error_msg); return false; } -- 1.7.2.5