From 35d4c2d13adb35053105155f56be2c6049d2007a Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Wed, 30 Oct 2013 10:28:49 +0100 Subject: [PATCH] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals Content-Type: text/plain; charset=utf-8 In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code. The bug is that the filter uses a pattern match instead of equals : next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'. Test plan : - Create a branch with code '1' and one with code '12' - Create budgets in both branches - Go to admin/aqbudgets.pl - Filter by branch '12' => You see only budgets of this branch - Filter by branch '1' => You see only budgets of this branch Signed-off-by: Marcel de Rooy --- admin/aqbudgets.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl index 42a39f7..229606e 100755 --- a/admin/aqbudgets.pl +++ b/admin/aqbudgets.pl @@ -296,7 +296,7 @@ if ($op eq 'add_form') { || $budget->{budget_name} =~ m/$filter_budgetname/i; } if ($filter_budgetbranch ) { - next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/; + next unless $budget->{budget_branchcode} eq $filter_budgetbranch; } ## TOTALS -- 1.7.7.6