Bugzilla – Attachment 2359 Details for
Bug 4994
ldap mapping inconsistancy: Net::LDAP returns lowercase names
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
lowercase all mappings before matching them with ldap
0001-Bug-4994-Net-LDAP-returns-lowercase-names.patch (text/plain), 1.32 KB, created by
Dobrica Pavlinusic
on 2010-07-13 21:29:20 UTC
(
hide
)
Description:
lowercase all mappings before matching them with ldap
Filename:
MIME Type:
Creator:
Dobrica Pavlinusic
Created:
2010-07-13 21:29:20 UTC
Size:
1.32 KB
patch
obsolete
>From 5efd53c1cefefa1f03b4defb475e02c65997192f Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Tue, 13 Jul 2010 23:26:35 +0200 >Subject: [PATCH] Bug 4994 - Net::LDAP returns lowercase names > >This requires us to specify all LDAP mappings in koha-conf.xml in lowercase, >instead of original case used withing LDAP. > >Compare readability of > ><userid is="hrEduPersonUniqueID" ></userid> > >(which doesn't work) with required (and non-intuitive) > ><userid is="hredupersonuniqueid" ></userid> >--- > C4/Auth_with_ldap.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index b25697c..00fd9fd 100644 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -210,7 +210,7 @@ sub ldap_entry_2_hash ($$) { > $debug and print STDERR "Finsihed \%memberhash has ", scalar(keys %memberhash), " keys\n", > "Referencing \%mapping with ", scalar(keys %mapping), " keys\n"; > foreach my $key (keys %mapping) { >- my $data = $memberhash{$mapping{$key}->{is}}; >+ my $data = $memberhash{ lc($mapping{$key}->{is}) }; # Net::LDAP returns all names in lowercase > $debug and printf STDERR "mapping %20s ==> %-20s (%s)\n", $key, $mapping{$key}->{is}, $data; > unless (defined $data) { > $data = $mapping{$key}->{content} || ''; # default or failsafe '' >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4994
:
2359
|
4070