Bugzilla – Attachment 23812 Details for
Bug 11445
it is possible for duplicate hold notifications to be sent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11445: avoid sending duplicate hold waiting notifications
Bug-11445-avoid-sending-duplicate-hold-waiting-not.patch (text/plain), 1.82 KB, created by
Galen Charlton
on 2013-12-25 17:48:45 UTC
(
hide
)
Description:
Bug 11445: avoid sending duplicate hold waiting notifications
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2013-12-25 17:48:45 UTC
Size:
1.82 KB
patch
obsolete
>From 9a61689e6d1d6ff0e97e719c4da890050e674f24 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Wed, 25 Dec 2013 17:44:19 +0000 >Subject: [PATCH] Bug 11445: avoid sending duplicate hold waiting > notifications > >This patch fixes a problem where a patron could receive duplicate >hold waiting notifications. For example, this could happen if a >circ operator checked in an item more than once and confirmed the >same hold each time. > >To test: > >[1] Set up a test patron that received hold waiting notifications. >[2] Put an item on hold for the patron, then check the item in > and confirm the hold. Verify that a hold notification is > sent (or inspect the message_queue table). >[3] Check the item in again and confirm the hold again. A duplicate > hold notification will be generated. >[4] Apply the patch. >[5] Repeat steps 2 and 3. This time, only one notification should be > generated. >[6] Verify that prove -v t/db_dependent/Reserves.t passes. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > C4/Reserves.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index d1bca25..8d83e87 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1257,7 +1257,12 @@ sub ModReserveAffect { > > # get request - need to find out if item is already > # waiting in order to not send duplicate hold filled notifications >- my $request = GetReserveInfo($borrowernumber, $biblionumber); >+ my $reserve_id = GetReserveId({ >+ borrowernumber => $borrowernumber, >+ biblionumber => $biblionumber, >+ }); >+ return unless defined $reserve_id; >+ my $request = GetReserveInfo($reserve_id); > my $already_on_shelf = ($request && $request->{found} eq 'W') ? 1 : 0; > > # If we affect a reserve that has to be transfered, don't set to Waiting >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11445
:
23811
|
23812
|
23842
|
23843
|
23852
|
23853