From d6f8e44a2a4639964e21f50b61bafd73cbd30de4 Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Fri, 10 Jan 2014 14:45:17 -0500 Subject: [PATCH] Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver --- circ/returns.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/returns.pl b/circ/returns.pl index 93f36f2..e924e86 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -281,7 +281,7 @@ if ($barcode) { $waiting_holds++; } } - if ($waiting_holds > 0) { + if ($waiting_holds && $waiting_holds > 0) { $template->param( waiting_holds => $waiting_holds, holdsborrowernumber => $borrower->{'borrowernumber'}, -- 1.8.5.2