From 738633de1f668f24a6d0314ffd3c53a4b93b60d2 Mon Sep 17 00:00:00 2001 From: Jared Camins-Esakov Date: Thu, 12 Sep 2013 14:39:29 -0400 Subject: [PATCH] Bug 10402 follow-up: fix perlcritic exception Perlcritic doesn't like the syntax keys $variable, and requires that you explicitly dereference a hashref to a hash before using keys. --- acqui/supplier.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acqui/supplier.pl b/acqui/supplier.pl index c480c2a..8161300 100755 --- a/acqui/supplier.pl +++ b/acqui/supplier.pl @@ -67,7 +67,7 @@ my $booksellerid = $query->param('booksellerid'); my $supplier = {}; if ($booksellerid) { $supplier = GetBookSellerFromId($booksellerid); - foreach ( keys $supplier ) { + foreach ( keys %{$supplier} ) { $template->{'VARS'}->{$_} = $supplier->{$_}; } $template->{'VARS'}->{'booksellerid'} = $booksellerid; -- 1.7.9.5