Bugzilla – Attachment 2474 Details for
Bug 5094
auth_by_bind authentication can fail even if given a correct password and userid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix for this bug
Auth_with_ldap.pm.patch (text/plain), 816 bytes, created by
Jeremy Crabtree
on 2010-08-05 14:32:37 UTC
(
hide
)
Description:
Proposed fix for this bug
Filename:
MIME Type:
Creator:
Jeremy Crabtree
Created:
2010-08-05 14:32:37 UTC
Size:
816 bytes
patch
obsolete
>diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index b25697c..e33b4ef 100755 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -124,8 +124,14 @@ sub checkpw_ldap { > } > > # FIXME dpavlin -- we really need $userldapentry leater on even if using auth_by_bind! >- my $search = search_method($db, $userid) or return 0; # warnings are in the sub >- $userldapentry = $search->shift_entry; >+ >+ # BUG #5094 >+ # 2010-08-04 JeremyC >+ # a $userldapentry is only needed if either updating or replicating are enabled >+ if($config{update} or $config{replicate}) { >+ my $search = search_method($db, $userid) or return 0; # warnings are in the sub >+ $userldapentry = $search->shift_entry; >+ } > > } else { > my $search = search_method($db, $userid) or return 0; # warnings are in the sub
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5094
: 2474