From b92defb7640f94a2702b971d14ca5c124032df71 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 28 Jan 2014 11:43:50 -0500 Subject: [PATCH] Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 --- C4/Circulation.pm | 19 +++++++++++++++++++ installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 +++++++ .../en/modules/admin/preferences/circulation.pref | 7 +++++++ 4 files changed, 34 insertions(+), 0 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index f8b204a..5d20b9e 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1755,6 +1755,25 @@ sub AddReturn { my $borrowernumber = $borrower->{'borrowernumber'} || undef; # we don't know if we had a borrower or not + my $yaml = C4::Context->preference('UpdateNotForLoanStatusOnCheckin'); + if ($yaml) { + $yaml = "$yaml\n\n"; # YAML is anal on ending \n. Surplus does not hurt + my $rules; + eval { $rules = YAML::Load($yaml); }; + if ($@) { + warn "Unable to parse UpdateNotForLoanStatusOnCheckin syspref : $@"; + } + else { + foreach my $key ( keys %$rules ) { + if ( $item->{notforloan} eq $key ) { + ModItem( { notforloan => $rules->{$key} }, undef, $itemnumber ); + last; + } + } + } + } + + # check if the book is in a permanent collection.... # FIXME -- This 'PE' attribute is largely undocumented. afaict, there's no user interface that reflects this functionality. if ( $hbr ) { diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 1668d37..ef433ef 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -395,6 +395,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('TrackClicks','0',NULL,'Track links clicked','Integer'), ('TransfersMaxDaysWarning','3',NULL,'Define the days before a transfer is suspected of having a problem','Integer'), ('TransferWhenCancelAllWaitingHolds','0',NULL,'Transfer items when cancelling all waiting holds','YesNo'), +('UpdateNotForLoanStatusOnCheckin', '', 'NULL', 'This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free'), ('UNIMARCAuthorityField100','afrey50 ba0',NULL,NULL,'Textarea'), ('UNIMARCAuthorsFacetsSeparator',', ',NULL,'UNIMARC authors facets separator','short'), ('UNIMARCField100Language','fre',NULL,'UNIMARC field 100 default language','short'), diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index f98daa7..30e5bcc 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -7945,6 +7945,13 @@ if (CheckVersion($DBversion)) { SetVersion($DBversion); } +$DBversion = "3.15.00.XXX"; +if (CheckVersion($DBversion)) { + $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('UpdateNotForLoanStatusOnCheckin', '', 'NULL', 'This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free');"); + print "Upgrade to $DBversion done (Bug 11629 - Add ability to update not for loan status on checkin)\n"; + SetVersion($DBversion); +} + =head1 FUNCTIONS =head2 TableExists($table) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref index 33ae4c9..380da1a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ -351,6 +351,13 @@ Circulation: no: "Don't" - calculate and update overdue charges when an item is returned. -
NOTE If you are doing hourly loans then you should have this on. + - + - pref: UpdateNotForLoanStatusOnCheckin + type: textarea + class: code + - This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value + - "it will be updated to the right-hand value. E.g. '-1: 0' will cause an item that was set to 'Ordered' to now be available for loan." + - Each pair of values should be on a separate line. Holds Policy: - - pref: AllowHoldPolicyOverride -- 1.7.2.5