Bugzilla – Attachment 24854 Details for
Bug 8753
Add forgot password link to OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Removed unnecessary argument in call to SendPasswordRecoveryEmail. Improved var naming
Removed-unnecessary-argument-in-call-to-SendPasswo.patch (text/plain), 2.25 KB, created by
Blou
on 2014-01-28 20:24:09 UTC
(
hide
)
Description:
Removed unnecessary argument in call to SendPasswordRecoveryEmail. Improved var naming
Filename:
MIME Type:
Creator:
Blou
Created:
2014-01-28 20:24:09 UTC
Size:
2.25 KB
patch
obsolete
>From 170f8d1e6ee557bc09dce0bd451f9442d175656f Mon Sep 17 00:00:00 2001 >From: Blou <philippe.blouin@inlibro.com> >Date: Tue, 28 Jan 2014 15:23:50 -0500 >Subject: [PATCH] Removed unnecessary argument in call to > SendPasswordRecoveryEmail. Improved var naming > >http://bugs.koha-community.org/show_bug.cgi?id=8753 >--- > C4/Members.pm | 8 +++----- > opac/opac-password-recovery.pl | 2 +- > 2 files changed, 4 insertions(+), 6 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index c6fe793..ee44313 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -2267,7 +2267,6 @@ $query is the CGI object, required to determine if http or https must be used > sub SendPasswordRecoveryEmail { > my $borrowernumber = shift; > my $email = shift; >- my $query = shift; > my $dbh = C4::Context->dbh; > my $username = GetMemberDetails($borrowernumber)->{userid}; > >@@ -2285,13 +2284,12 @@ sub SendPasswordRecoveryEmail { > #define to/from emails > my $kohaEmail = C4::Context->preference( 'KohaAdminEmailAddress' ); > >+ my $query = new CGI; > #create link >- my $https = $query->https() ? "https://" : "http://"; >- my $uuidLink = $https . C4::Context->preference( 'OPACBaseURL' ) . "/cgi-bin/koha/opac-password-recovery.pl?uniqueKey=$uuid_str"; >- #warn $uuidLink; >+ my $protocol = $query->https() ? "https://" : "http://"; >+ my $uuidLink = $protocol . C4::Context->preference( 'OPACBaseURL' ) . "/cgi-bin/koha/opac-password-recovery.pl?uniqueKey=$uuid_str"; > > #build email content >- my $query = new CGI; > my ( $template2, $borrower_number, $cookie ) = C4::Auth::get_template_and_user( > { > template_name => "opac-send-password-recovery.tmpl", >diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl >index 3ae4cbf..7b03ad4 100755 >--- a/opac/opac-password-recovery.pl >+++ b/opac/opac-password-recovery.pl >@@ -102,7 +102,7 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) { > } > else { > #generate uuid and send recovery email >- if ( SendPasswordRecoveryEmail( $borrower_number, $email, $query ) ) { >+ if ( SendPasswordRecoveryEmail( $borrower_number, $email ) ) { > # if it works.... > $template->param( > mail_sent => 1, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8753
:
21502
|
21512
|
21521
|
21849
|
22175
|
22430
|
24586
|
24780
|
24781
|
24846
|
24853
|
24854
|
24855
|
24862
|
24906
|
24907
|
24908
|
25038
|
25039
|
25051
|
29111
|
33175
|
33176
|
34472
|
36819
|
37492
|
39049
|
39144
|
39165
|
39166
|
39167
|
39168
|
39827
|
41181
|
41192
|
41193
|
41455
|
41686
|
41687
|
41688
|
41706
|
43017
|
43183
|
43576
|
44305
|
44306
|
44307
|
44308
|
44309
|
44310
|
44311
|
44323
|
44324
|
44325
|
44326
|
44327
|
44329
|
44330
|
45209
|
45210
|
45211
|
45212
|
45213
|
45214
|
45215
|
45223
|
45224
|
45225
|
45226
|
45227
|
45228
|
45229
|
45230
|
46379
|
47164
|
47165
|
47166
|
47167
|
47168
|
47169
|
47170
|
47171
|
47357
|
47366