From a9dd2881bbf8d4137b4f9863976d625ed79ec2f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= Date: Sat, 1 Feb 2014 09:49:38 +0100 Subject: [PATCH] [PASSED QA] Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variables are not defined in template since opacbookbag is disabled. To reproduce this bug: - Choose bootstrap OPAC theme - Enable virtualsheves syspref - Disable opacbookbag syspref - Open a biblio record in OPAC detail page - You will observe that items holding tabs are not displayed as tabs but as a buletted list Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes QA script and all tests. Confirmed display problem exists without the patch and is solved by it. Ideally we would avoid having the cart messages in the template when the feature is deactivated, but this is ok for now. --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index c3ce588..8bb4ccd 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -108,7 +108,7 @@ //