Bugzilla – Attachment 24988 Details for
Bug 10851
Add missing statuses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10851: FIX QA issues
PASSED-QA-Bug-10851-FIX-QA-issues.patch (text/plain), 1.92 KB, created by
Katrin Fischer
on 2014-02-02 16:44:25 UTC
(
hide
)
Description:
[PASSED QA] Bug 10851: FIX QA issues
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-02-02 16:44:25 UTC
Size:
1.92 KB
patch
obsolete
>From 093c04070542be42e1ea7845fad695a0fb74cceb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 21 Jan 2014 09:28:24 +0100 >Subject: [PATCH] [PASSED QA] Bug 10851: FIX QA issues > >This patch fixes following warnings: > > FAIL C4/Serials.pm > FAIL valid > Useless use of a constant (43) in void context > Useless use of a constant (41) in void context > Useless use of a constant (44) in void context > Useless use of a constant (42) in void context > Useless use of a constant (4) in void context > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > C4/Serials.pm | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index e745458..2fb639b 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -425,7 +425,7 @@ sub PrepareSerialsData { > } > } > $subs->{ "status" . $subs->{'status'} } = 1; >- if ( grep { $_ == $subs->{status} } ( 1, 3, 4, 41, 42, 43, 44, 7 ) ) { >+ if ( grep { $_ == $subs->{status} } qw( 1 3 4 41 42 43 44 7 ) ) { > $subs->{"checked"} = 1; > } > >@@ -1250,10 +1250,11 @@ sub ModSerialStatus { > if ( $status == 2 || ($oldstatus == 2 && $status != 2) ) { > _update_receivedlist($subscriptionid); > } >- if( grep { $_ == $status } ( 4, 41, 42, 43, 44, 5 ) >+ my @missing_statuses = qw( 4 41 42 43 44 ); >+ if ( ( grep { $_ == $status } ( @missing_statuses, 5 ) ) > || ( >- grep { $_ == $oldstatus } ( 4, 41, 42, 43, 44 ) >- && ! grep { $_ == $status } ( 4, 41, 42, 43, 44 ) ) >+ ( grep { $_ == $oldstatus } @missing_statuses ) >+ && ! ( grep { $_ == $status } @missing_statuses ) ) > || ($oldstatus == 5 && $status != 5)) { > _update_missinglist($subscriptionid); > } >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10851
:
20936
|
20958
|
22460
|
22593
|
24119
|
24593
|
24736
|
24987
| 24988 |
24989