Bugzilla – Attachment 25043 Details for
Bug 11684
More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user
bug-11684---mixed-content-warnings-using-SSL-with-.patch (text/plain), 6.00 KB, created by
Liz Rea
on 2014-02-05 01:04:07 UTC
(
hide
)
Description:
bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2014-02-05 01:04:07 UTC
Size:
6.00 KB
patch
obsolete
>From 0724538a0ef84d0149a2a2d123ada891a46c51ed Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Wed, 5 Feb 2014 13:59:09 +1300 >Subject: [PATCH] bug 11684 - mixed content warnings using SSL with amazon - > opac-readingrecord and opac-user > >To test: > >* Enable Amazon images in the system preferences >* Issue a book you know will have images for, verify that without SSL >1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord >2. the image source is from an Amazon url that uses http:// >3. the images are the right size, and look ok >* Do the same using https, verify that with SSL >1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord >2. the image source is from an Amazon url that uses https:// >3. the images are the right size, and look ok >--- > .../bootstrap/en/modules/opac-readingrecord.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 12 ++++++++---- > 2 files changed, 9 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index 80e9f1d..f0f00ab 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -72,7 +72,7 @@ > <td> > [% IF OPACAmazonCoverImages %] > [% IF issue.normalized_isbn %] >- <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% issue.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> >+ <a href="http://www.amazon.com/gp/reader/[% issue.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"> > [% IF using_https %]<img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% issue.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" /> > [% ELSE %]<img border="0" src="http://images.amazon.com/images/P/[% issue.normalized_isbn %].01.THUMBZZZZ.jpg" alt="" class="item-thumbnail" /> [% END %] </a> > [% ELSE %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 26cec5b..233a045 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -130,11 +130,11 @@ > > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( ISSUE.normalized_isbn ) %] >- <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% ISSUE.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"> >+ <a href="http://www.amazon.com/gp/reader/[% ISSUE.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"> > [% IF using_https %] >- <img src="https://images-na.ssl-images-amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" /></a> >+ <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="item-thumbnail" class="item-thumbnail" /></a> > [% ELSE %] >- <img border="0" src="http://images.amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="item-thumbnail" /> >+ <img border="0" src="http://images.amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="item-thumbnail" /> > [% END %] > [% ELSE %] > <a href="#"><span class="no-image">No cover image available</span></a> >@@ -375,7 +375,11 @@ > <td class="jacketcell"> > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( OVERDUE.normalized_isbn ) %] >- <a href="http://www.amazon.com/gp/reader/[% OVERDUE.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"><img src="http://images.amazon.com/images/P/[% OVERDUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" /></a> >+ [% IF using_https %] >+ <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% OVERDUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="item-thumbnail" class="item-thumbnail" /></a> >+ [% ELSE %] >+ <img border="0" src="http://images.amazon.com/images/P/[% OVERDUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="item-thumbnail" /> >+ [% END %] > [% ELSE %] > <a href="#"><span class="no-image">No cover image available</span></a> > [% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11684
:
25043
|
26848
|
26852
|
26888