Bugzilla – Attachment 25113 Details for
Bug 11707
Additional attributes broken for category code with space
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11707 - Additional attributes broken for category code with space
Bug-11707---Additional-attributes-broken-for-categ.patch (text/plain), 1.72 KB, created by
Fridolin Somers
on 2014-02-07 09:19:41 UTC
(
hide
)
Description:
Bug 11707 - Additional attributes broken for category code with space
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2014-02-07 09:19:41 UTC
Size:
1.72 KB
patch
obsolete
>From 1f3e08c7cf362faaab12d985a4b3354d071a3810 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 7 Feb 2014 10:13:39 +0100 >Subject: [PATCH] Bug 11707 - Additional attributes broken for category code > with space > >When editing additional attributes of a patron of a category with a code with space (ie "CAT 3"), the Javascript is broken and Additional attributes are not displayed. > >This patch corrects by adding simple quotes aroud category code in JS code. > >Test plan : >- Create an patron additional attribute >- Create a new patron category with a space in code. ie "CAT 3" >- Create a new patron of this category : /cgi-bin/koha/members/memberentry.pl?op=add&categorycode=CAT 3 >=> Without patch the JS is broken (Syntax error, unrecognized expression: [data-category_code=CAT 3]) and additional attributes are not displayed. >=> With patch the JS is not broken and additional attributes are displayed and can be edited. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 05b5b4e..1ddb001 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -99,7 +99,7 @@ > } > var mytables = $(".attributes_table"); > $(mytables).find("li").hide(); >- $(mytables).find(" li[data-category_code="+category_code+"]").show(); >+ $(mytables).find(" li[data-category_code='"+category_code+"']").show(); > $(mytables).find(" li[data-category_code='']").show(); > } > >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11707
:
25113
|
25301
|
25567