From dc0c5a0f8254f0be2a6d2e323eb22c826f854802 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Tue, 18 Feb 2014 09:47:32 -0500
Subject: [PATCH] Bug 11783 - Record level unavailable holds sending empty CD field rather than item barcode

If a patron has a record-level hold that is unavailable, any patron
information request will send back an empty CD field when this field
should have an item barcode in it. This is due to a minor error in
ILS::Patron::_get_outstanding_hodsl where GetItemnumbersForBiblio is
assumed to return an array but in reality returns an arrayref.

Test Plan:
1) Create a record level hold for a patron and record
2) Using SIP2, make a patron information request
3) Note the empty CD fields
4) Apply this patch, restart SIP server
5) Repeat step 2
6) Note the CD field now has a barcode
---
 C4/SIP/ILS/Patron.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm
index 5b835ca..4ccd21b 100644
--- a/C4/SIP/ILS/Patron.pm
+++ b/C4/SIP/ILS/Patron.pm
@@ -402,7 +402,7 @@ sub _get_outstanding_holds {
         else {
             # We need to return a barcode for the biblio so the client
             # can request the biblio info
-            $item = ( GetItemnumbersForBiblio($h->{biblionumber}) )[0];
+            $item = ( GetItemnumbersForBiblio($h->{biblionumber}) )->[0];
         }
         $h->{barcode} = GetBarcodeFromItemnumber($item);
     }
-- 
1.7.2.5