From 1e54751f3c699aecbdb3c268c7474242e82d41eb Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 20 Feb 2014 11:38:53 -0500 Subject: [PATCH] Bug 11794 - opacSerialDefaultTab being ignored Content-Type: text/plain; charset="utf-8" The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. --- .../bootstrap/en/modules/opac-auth-detail.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- .../opac-tmpl/prog/en/modules/opac-auth-detail.tt | 2 +- koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt index 3c5b05f..18a942e 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt @@ -108,7 +108,7 @@
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 46f73db..da209eb 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -513,7 +513,7 @@
    [% IF ( defaulttab == 'holdings' ) %] -
  • +
  • [% ELSE %]
  • [% END %] @@ -555,7 +555,7 @@ [% END %] [% IF ( subscriptionsnumber ) %] - [% IF ( defaulttab == 'subscriptions' ) %]
  • [% ELSE %]
  • [% END %] + [% IF ( defaulttab == 'subscriptions' ) %]
  • [% ELSE %]
  • [% END %] Subscriptions
  • [% END %] @@ -575,7 +575,7 @@ [% END %] [% IF ( serialcollection ) %] - [% IF ( defaulttab == 'serialcollection' ) %]
  • [% ELSE %]
  • [% END %] + [% IF ( defaulttab == 'serialcollection' ) %]
  • [% ELSE %]
  • [% END %] Serial collection
  • [% END %] diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt index 78bc5b9..1a46f84 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-detail.tt @@ -92,7 +92,7 @@ $(document).ready(function() { [% END %]
    diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt index 3f3ade7..3935180 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ -937,7 +937,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
      - [% IF ( defaulttab == 'holdings' ) %]
    • [% ELSE %]
    • [% END %] + [% IF ( defaulttab == 'holdings' ) %]
    • [% ELSE %]
    • [% END %] [% IF SeparateHoldings %][% LoginBranchname %] holdings[% ELSE %]Holdings[% END %] ( [% itemloop.size || 0 %] )
    • [% IF (SeparateHoldings) %] @@ -976,7 +976,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { [% END %] [% END %] [% IF ( subscriptionsnumber ) %] - [% IF ( defaulttab == 'subscriptions' ) %]
    • [% ELSE %]
    • [% END %] + [% IF ( defaulttab == 'subscriptions' ) %]
    • [% ELSE %]
    • [% END %] Subscriptions
    • [% END %] @@ -995,7 +995,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { [% END %][% END %] [% IF ( serialcollection ) %] - [% IF ( defaulttab == 'serialcollection' ) %]
    • [% ELSE %]
    • [% END %] + [% IF ( defaulttab == 'serialcollection' ) %]
    • [% ELSE %]
    • [% END %] Serial collection
    • [% END %] -- 1.7.9.5