Bugzilla – Attachment 25564 Details for
Bug 11819
Don't show catalog edit menu if user has no edit permissions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11819 - Don't show catalog edit menu if user has no edit permissions
PASSED-QA-Bug-11819---Dont-show-catalog-edit-menu-.patch (text/plain), 2.24 KB, created by
Katrin Fischer
on 2014-02-23 21:58:53 UTC
(
hide
)
Description:
[PASSED QA] Bug 11819 - Don't show catalog edit menu if user has no edit permissions
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-02-23 21:58:53 UTC
Size:
2.24 KB
patch
obsolete
>From 757a6cf1a46cf25dbfe3d52ca61432c9ad2c88e3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 21 Feb 2014 14:52:22 -0500 >Subject: [PATCH] [PASSED QA] Bug 11819 - Don't show catalog edit menu if user > has no edit permissions >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Currently if the logged in user lacks any cataloging permissions the >bibliographic detail page (catalogue/detail.pl) still shows the Edit >button, but with an empty dropdown menu. This patch corrects the toolbar >include so that the button will not appear at all. > >To test, view the biblio detail page as a user with various combinations >of the following permissions: > >- edit_items >- edit_catalogue >- items_batchmod >- items_batchdel > >The edit button should appear with the correct set of links when the >user has any combination of the above permissions. If user has none the >button should not appear. > >Followed test plan, patch behaves as expected >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as expected, passes all tests and QA script. >Template only change. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index 63b22a4..e2271df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -149,6 +149,7 @@ CAN_user_serials_create_subscription ) %] > </div> > [% END %] > >+[% IF ( CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items || CAN_user_tools_items_batchmod || CAN_user_tools_items_batchdel ) %] > <div class="btn-group"> > <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="icon-pencil"></i> Edit <span class="caret"></span></button> > <ul class="dropdown-menu"> >@@ -184,6 +185,7 @@ CAN_user_serials_create_subscription ) %] > > </ul> > </div> >+[% END %] > > <div class="btn-group"> > <button class="btn btn-small dropdown-toggle" data-toggle="dropdown"><i class="icon-download-alt"></i> Save <span class="caret"></span></button> >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11819
:
25550
|
25557
| 25564