From 7fac04835ae0670ba1d69b61313f0d349fb60c7d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 25 Feb 2014 15:55:03 -0500 Subject: [PATCH] [SIGNED OFF] Bug 11833 - Filtering on saved report subgroup doesn't work Filtering the list of saved reports by subgroup doesn't work because the filtering JavaScript was not updated when the table columns changed with Bug 3134. This patch corrects the target column for filtering. To test you must have multiple saved reports within one group, and at least one of those in a subgroup. - Apply the patch and go to Reports -> Use saved. - Click the tab for the group which contains your reports. - Choose the subgroup you want to filter on from the subgroup dropdown. The list of reports should be correctly filtered by your subgroup. NOTE: It seems weird to have the number of columns displayed change when filtered, but this patch does correct the filtering. Signed-off-by: Mark Tompsett --- .../en/modules/reports/guided_reports_start.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 2ac91d6..cff39b7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -116,11 +116,11 @@ $(document).ready(function(){ var sg_id = $(selected).val(); var sg_name = $(selected).text(); if (sg_id.length > 0) { - rtable.fnFilter('^' + sg_name + '$', 4, true, true, true, false); - rtable.fnSetColumnVis(4, false); + rtable.fnFilter('^' + sg_name + '$', 5, true, true, true, false); + rtable.fnSetColumnVis(5, false); } else { - rtable.fnFilter('', 4); - rtable.fnSetColumnVis(4, true); + rtable.fnFilter('', 5); + rtable.fnSetColumnVis(5, true); } }); -- 1.7.9.5