Bugzilla – Attachment 26503 Details for
Bug 11369
Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11369 - Correct usage of me.searchid in browser.js
PASSED-QA-Bug-11369---Correct-usage-of-mesearchid-.patch (text/plain), 3.87 KB, created by
Katrin Fischer
on 2014-03-21 07:34:57 UTC
(
hide
)
Description:
[PASSED QA] Bug 11369 - Correct usage of me.searchid in browser.js
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-03-21 07:34:57 UTC
Size:
3.87 KB
patch
obsolete
>From b391a12fe2c5c0d5ee5a382af4d3e6c778f43eca Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 26 Feb 2014 17:03:13 +0100 >Subject: [PATCH] [PASSED QA] Bug 11369 - Correct usage of me.searchid in > browser.js > >In browser.js, at creation of browser, the searchid is transmited to >JS object into me.searchid. >To be consistant, me.searchid should always be use, never searchid alone. >In browseRecords function, setting searchid as parameter is useless >because it is defined in me.searchid. > >Test with test plan of Bug 10404 > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/js/browser.js | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/js/browser.js b/koha-tmpl/intranet-tmpl/js/browser.js >index c203d3e..4ebc29c 100644 >--- a/koha-tmpl/intranet-tmpl/js/browser.js >+++ b/koha-tmpl/intranet-tmpl/js/browser.js >@@ -5,18 +5,18 @@ KOHA.browser = function (searchid, biblionumber) { > this.searchid = searchid; > > if (me.searchid) { >- var cookie = $.cookie(searchid) >+ var cookie = $.cookie(me.searchid) > if (cookie) { > me.searchCookie = JSON.parse(cookie); > } > } > >- var browseRecords = function (searchid, movement) { >+ var browseRecords = function (movement) { > var newSearchPos = me.curPos + movement; > if (newSearchPos > me.searchCookie.results.length - 1) { >- window.location = '/cgi-bin/koha/catalogue/search.pl?' + decodeURIComponent(me.searchCookie.query) + '&limit=' + decodeURIComponent(me.searchCookie.limit) + '&sort=' + me.searchCookie.sort + '&gotoPage=detail.pl&gotoNumber=first&searchid=' + searchid + '&offset=' + newSearchPos; >+ window.location = '/cgi-bin/koha/catalogue/search.pl?' + decodeURIComponent(me.searchCookie.query) + '&limit=' + decodeURIComponent(me.searchCookie.limit) + '&sort=' + me.searchCookie.sort + '&gotoPage=detail.pl&gotoNumber=first&searchid=' + me.searchid + '&offset=' + newSearchPos; > } else if (newSearchPos < 0) { >- window.location = '/cgi-bin/koha/catalogue/search.pl?' + decodeURIComponent(me.searchCookie.query) + '&limit=' + decodeURIComponent(me.searchCookie.limit) + '&sort=' + me.searchCookie.sort + '&gotoPage=detail.pl&gotoNumber=last&searchid=' + searchid + '&offset=' + (me.offset - me.searchCookie.pagelen); >+ window.location = '/cgi-bin/koha/catalogue/search.pl?' + decodeURIComponent(me.searchCookie.query) + '&limit=' + decodeURIComponent(me.searchCookie.limit) + '&sort=' + me.searchCookie.sort + '&gotoPage=detail.pl&gotoNumber=last&searchid=' + me.searchid + '&offset=' + (me.offset - me.searchCookie.pagelen); > } else { > window.location = window.location.href.replace('biblionumber=' + biblionumber, 'biblionumber=' + me.searchCookie.results[newSearchPos]); > } >@@ -86,11 +86,11 @@ KOHA.browser = function (searchid, biblionumber) { > $('#menu').before('<div class="browse-controls"><div class="browse-controls-inner"><div class="browse-label"><a href="' + searchURL + '" id="browse-return-to-results" class="browse-button">' + BROWSER_RETURN_TO_SEARCH + '</a></div><div class="browse-prev-next">' + prevbutton + nextbutton + '</div></div></div>'); > $('a#browse-previous').click(function (ev) { > ev.preventDefault(); >- browseRecords(searchid, -1); >+ browseRecords(-1); > }); > $('a#browse-next').click(function (ev) { > ev.preventDefault(); >- browseRecords(me.searchid, 1); >+ browseRecords(1); > }); > $('a[href*="biblionumber="]').click(function (ev) { > ev.preventDefault(); >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11369
:
23389
|
23390
|
25662
|
25663
|
25667
|
25669
|
25729
|
25730
|
25731
|
25732
|
26501
|
26502
| 26503 |
26504