From 3751ddf5ad8798d9e60066d9047898051b41a72a Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 24 Mar 2014 10:11:47 +0100 Subject: [PATCH] Bug 10613: FIX QA issues This patch fixes the following QA issue: FAIL acqui/invoice.pl FAIL valid Useless use of private variable in void context It fixes also the booksellerid variable (supplierid is not used anymore in the template). --- acqui/invoice.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acqui/invoice.pl b/acqui/invoice.pl index 8802acb..acb4893 100755 --- a/acqui/invoice.pl +++ b/acqui/invoice.pl @@ -123,7 +123,7 @@ foreach my $order (@$orders) { $foot{$$line{gstgsti}}{totalgsti} += $$line{totalgsti}; $total_gsti += $$line{totalgsti}; - my %row = %{ $order, $line }; + my %row = ( %$order, %$line ); $row{'orderline'} = $row{'parent_ordernumber'}; push @orders_loop, \%row; } @@ -149,7 +149,7 @@ $template->param( invoiceid => $details->{'invoiceid'}, invoicenumber => $details->{'invoicenumber'}, suppliername => $details->{'suppliername'}, - supplierid => $details->{'supplierid'}, + booksellerid => $details->{'supplierid'}, datereceived => $details->{'datereceived'}, billingdate => C4::Dates->new($details->{'billingdate'}, "iso")->output(), invoiceclosedate => $details->{'invoiceclosedate'}, -- 1.7.10.4