@@ -, +, @@ --- C4/Overdues.pm | 9 ++++----- circ/circulation.pl | 2 +- members/moremember.pl | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) --- a/C4/Overdues.pm +++ a/C4/Overdues.pm @@ -661,21 +661,20 @@ sub GetFine { =head2 GetItemCharges - $charges = GetItemCharges( $borrowernumber, $itemnumber ) + $charges = GetItemCharges( $itemnumber , $borrowernumber) Gets fines and issue charge for item from accountlines. Icluding all outstanding amount for specific item, also from previous issue of this item. - + =cut sub GetItemCharges { - my ( $borrowernumber, $itemnumber ) = @_; - + my ( $itemnumber, $borrowernumber ) = @_; my $dbh = C4::Context->dbh(); my $query = "SELECT SUM(amountoutstanding) FROM accountlines WHERE borrowernumber = ? AND itemnumber = ? "; my $sth = $dbh->prepare( $query ); $sth->execute( $borrowernumber, $itemnumber ); - return $sth->fetchrow_arrayref()->[0]; + return $sth->fetchrow_arrayref()->[0] || 0; } =head2 NumberNotifyId --- a/circ/circulation.pl +++ a/circ/circulation.pl @@ -480,7 +480,7 @@ sub build_issue_data { $it->{'itemtype'} = ( C4::Context->preference( 'item-level_itypes' ) ) ? $it->{'itype'} : $it->{'itemtype'}; $it->{'charge'} = GetItemCharges( - $it->{'borrowernumber'}, $it->{'itemnumber'} + $it->{'itemnumber'}, $it->{'borrowernumber'} ); $it->{'charge'} = sprintf("%.2f", $it->{'charge'}); my ($can_renew, $can_renew_error) = CanBookBeRenewed( --- a/members/moremember.pl +++ a/members/moremember.pl @@ -504,7 +504,7 @@ sub build_issue_data { } #find all charges for an item - my $charge = GetItemCharges( $borrowernumber, $issue->{itemnumber} ); + my $charge = GetItemCharges( $issue->{itemnumber}, $borrowernumber ); my $getiteminfo = GetBiblioFromItemNumber( $issue->{'itemnumber'} ); my $itemtypeinfo = getitemtypeinfo( (C4::Context->preference('item-level_itypes')) ? $getiteminfo->{'itype'} : $getiteminfo->{'itemtype'} ); --