Bugzilla – Attachment 26758 Details for
Bug 12019
funds displayed on acquisition home show funds of all branches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12019: If a fund has a restriction, a owner is mandatory
Bug-12019-If-a-fund-has-a-restriction-a-owner-is-m.patch (text/plain), 1.59 KB, created by
Jonathan Druart
on 2014-04-02 11:33:10 UTC
(
hide
)
Description:
Bug 12019: If a fund has a restriction, a owner is mandatory
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-04-02 11:33:10 UTC
Size:
1.59 KB
patch
obsolete
>From 56156c4fa5ae6bb4a37a20e98dcb6d5e78969b74 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 2 Apr 2014 13:28:57 +0200 >Subject: [PATCH] Bug 12019: If a fund has a restriction, a owner is mandatory > >The C4::Budgets::CanUserUseBudget assumes that budget_owner_id is >set if a restriction (budget_permission) exists. >see > && $budget->{budget_owner_id} > && $budget->{budget_owner_id} != $borrower->{borrowernumber} > >Test plan: >Edit a fund and try to save it with a limitation and no owner. It should >not be possible. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt >index aba7bd6..25a85cf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt >@@ -132,6 +132,14 @@ var MSG_PARENT_BENEATH_BUDGET = "- " + _("New budget-parent is beneath budget") > _alertString += result; > } > >+ // If a restriction is defined, an owner should be defined too. >+ if ( $("#budget_permission").val() > 0 ) { >+ var budget_owner_id = $("#budget_owner_id").val(); >+ if ( budget_owner_id == 0 || budget_owner_id.length <= 0 ) { >+ _alertString += _("- If a restriction is defined, you must define an owner for this fund.") >+ } >+ } >+ > if (_alertString.length==0) { > document.Aform.submit(); > } else { >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12019
:
26710
|
26757
|
26758
|
26897
|
26898
|
27088
|
27147
|
27148
|
27149
|
27282
|
27283