Bugzilla – Attachment 26890 Details for
Bug 11489
OPAC search results in 404 error when the only search result is supressed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11489: Show facets only if there is result to display
PASSED-QA-Bug-11489-Show-facets-only-if-there-is-r.patch (text/plain), 2.34 KB, created by
Katrin Fischer
on 2014-04-07 22:33:06 UTC
(
hide
)
Description:
[PASSED QA] Bug 11489: Show facets only if there is result to display
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-04-07 22:33:06 UTC
Size:
2.34 KB
patch
obsolete
>From ea482b5c14db26c7e1881db18022178b05ea0a2a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 9 Jan 2014 17:53:04 +0100 >Subject: [PATCH] [PASSED QA] Bug 11489: Show facets only if there is result to > display > >If all results are hidden, the facets are displayed. >With this patch, the facets are hidden too. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Michot <nmichot@voila.fr> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script. Tested: > >- Record with 1 lost item, result list = 1 > - Verified without both patches 404 error page is shown > - Verified with 1st patch, no results page is shown > - Verified with 2nd patch, the still showing facets are gone >- Record with 1 lost item, result list > 1 > - Record is hidden from result list, but > - result count is wrong > - result numbering is wrong > > This is an old problem, just noting >- Record with 1 lost and 1 available item, result list = 1 > - Detail page is shown, only lost item is hidden >- Record with 1 lost and 1 available item, result list > 1 > - Only available item is shown in result list > >Also checked that the lost item shows up with hidelostitems off. >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 2 +- > koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >index a55dbc4..d4fff99 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >@@ -1,4 +1,4 @@ >-[% IF ( opacfacets && facets_loop ) %] >+[% IF ( opacfacets && facets_loop && total ) %] > <div id="search-facets"> > <h4><a href="#" class="menu-collapse-toggle">Refine your search</a></h4> > <ul class="menu-collapse"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >index 88e45db..107bf24 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >@@ -1,4 +1,4 @@ >-[% IF ( opacfacets ) %] >+[% IF ( opacfacets ) && total %] > [% IF ( facets_loop ) %] > <div id="search-facets"> > <h4>Refine your search</h4> >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11489
:
23989
|
23990
|
24291
|
24292
|
24294
|
24496
|
24497
|
24733
|
26061
|
26062
|
26889
| 26890