From b67dcebe2726f0d03e8c22a4be284fc64aad5e1a Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 11 Apr 2014 11:04:54 +0200 Subject: [PATCH] Bug 8992: qa-followup: replace given/when with if/elsif --- opac/opac-idref.pl | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/opac/opac-idref.pl b/opac/opac-idref.pl index 0bb3136..14dc8fd 100755 --- a/opac/opac-idref.pl +++ b/opac/opac-idref.pl @@ -61,20 +61,18 @@ for my $role_node ( @results ) { : ($v); for my $node ( @nodes ) { while ( ( $k, $v ) = each %$node ) { - given ( $k ) { - when ( "roleName" ) { - $role_name = $v; - $role_data->{role_name} = $role_name; - } - when ( "count" ) { - $role_data->{count} = $v; - } - when ( "doc" ) { - push @{ $role_data->{docs} }, $v; - } - default { - # unimarcCode and marc21Code - } + if ( $k eq 'roleName' ) { + $role_name = $v; + $role_data->{role_name} = $role_name; + } + elsif ( $k eq 'count' ) { + $role_data->{count} = $v; + } + elsif ( $k eq 'doc' ) { + push @{ $role_data->{docs} }, $v; + } + else { + # unimarcCode and marc21Code } } } -- 1.7.10.4